Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] M1 Mac & Rosetta #5115

Closed
segersniels opened this issue Dec 7, 2020 · 33 comments
Closed

[Question] M1 Mac & Rosetta #5115

segersniels opened this issue Dec 7, 2020 · 33 comments

Comments

@segersniels
Copy link

segersniels commented Dec 7, 2020

Has there been any progress made on creating an ARM compatible build for the new M1 Macs so everything isn't executed through Rosetta?

Sorry if this has been discussed elsewhere before.

@Stanzilla
Copy link
Contributor

https://github.com/vercel/hyper/runs/1561963547 has an arm64 artifact, can you try it?

@segersniels
Copy link
Author

segersniels commented Dec 17, 2020

https://github.com/vercel/hyper/runs/1561963547 has an arm64 artifact, can you try it?

I'm getting the following error when trying to run it:

“Hyper” is damaged and can’t be opened. You should move it to the Bin.

@andrewnorell
Copy link

@Stanzilla I got the same issue as @segersniels when attempting to run the arm64 artifact

@Stanzilla
Copy link
Contributor

Yeah I think I know what it is, will be fixed soonish

@shinriyo
Copy link

I am looking for M1 native support

@mindesik
Copy link

Any news?

@Stanzilla
Copy link
Contributor

Still have to fix the CI to properly upload the artifact

@Stanzilla
Copy link
Contributor

@xcity
Copy link

xcity commented Jan 4, 2021

I tried this new build, it shows file is damaged, cannot open.

@Qetesh
Copy link

Qetesh commented Jan 4, 2021

Try https://github.com/vercel/hyper/suites/1759175736/artifacts/33489701

I tried "sudo xattr -rd com.apple.quarantine /Applications/Hyper.app",and it shows

Uncaught Exception:
Error: `node-pty` failed to load. Typically this means that it was built incorrectly. Please check the `readme.md` to more info.
at createNodePtyError (/Applications/Hyper.app/Contents/Resources/app.asar/session.js:31:34)
at Object.<anonymous> (/Applications/Hyper.app/Contents/Resources/app.asar/session.js:38:11)
at Module._compile (internal/modules/cjs/loader.js:1152:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1173:10)
at Module.load (internal/modules/cjs/loader.js:992:32)
at Module._load (internal/modules/cjs/loader.js:885:14)
at Function.f._load (electron/js2c/asar_bundle.js:5:12738)
at Function._load (/Applications/Hyper.app/Contents/Resources/app.asar/plugins.js:94:37)
at Module.require (internal/modules/cjs/loader.js:1032:19)
at require (internal/modules/cjs/helpers.js:72:18)

@mindesik
Copy link

mindesik commented Jan 4, 2021

Still broken

@segersniels
Copy link
Author

@Stanzilla Anything we can do to assist?

@Stanzilla
Copy link
Contributor

@segersniels I mean you can try building it locally and see if that works, I don't have a M1 mac to do that.

@mindesik
Copy link

mindesik commented Jan 4, 2021

Building canary is working on M1, I'm using it right now

@segersniels
Copy link
Author

Building canary is working on M1, I'm using it right now

Hmm I'm receiving the same error as reported above building from canary. Are you sure you are running the arm64 version?

@mindesik
Copy link

mindesik commented Jan 4, 2021

Yes. I'm also have node and yarn for arm64.

@mindesik
Copy link

mindesik commented Jan 4, 2021

CleanShot 2021-01-05 at 03 27 20@2x

@segersniels
Copy link
Author

Aha, so apparently building using node 14 (which doesn't run natively on m1) causes the above error @Stanzilla. Building using 15 does seem to work now and hyper is running natively.

@segersniels
Copy link
Author

@mindesik Thanks for clarifying that you were using node 15 👍

@Stanzilla
Copy link
Contributor

Updated the CI to node 15, seems like there is still more to do though: https://github.com/vercel/hyper/runs/1645081308

@mindesik
Copy link

mindesik commented Jan 4, 2021

https://github.com/vercel/hyper/runs/1645081308#step:7:165

I think it must use MacOSX11.1.sdk instead of MacOSX10.15.sdk

@segersniels
Copy link
Author

segersniels commented Jan 4, 2021

Exactly. It seems that the runs-on: macos-latest is starting the CI under version 10.15.7:

Operating System
  Mac OS X
  10.15.7
  19H15

Can you see if manually defining macos-11.0 (or later) enforces anything?

@Stanzilla
Copy link
Contributor

I just did that, yeah

@Stanzilla
Copy link
Contributor

@Qetesh
Copy link

Qetesh commented Jan 5, 2021

Can run normally👍, very fast

How about this then https://github.com/vercel/hyper/suites/1764441117/artifacts/33639826

@segersniels
Copy link
Author

segersniels commented Jan 5, 2021

I get the following (using that artifact) again, even though I was able to build and run it locally 🤔 :

“Hyper” is damaged and can’t be opened. You should move it to the Bin.

@yklcs
Copy link

yklcs commented Feb 7, 2021

How about this then https://github.com/vercel/hyper/suites/1764441117/artifacts/33639826

Opening app fails with "damaged and can't be opened", but it opens and runs correctly after sudo xattr -rd com.apple.quarantine. What could be causing the warning?

@mbokman
Copy link

mbokman commented Feb 28, 2021

Except for having to do the sudo xattr -rd com.apple.quarantine trick on the https://github.com/vercel/hyper/suites/1764441117/artifacts/33639826 artifact, it seems to work very good for me. Any chance on this becoming available as part of the brew hyper-canary cask?

@sbinlondon
Copy link

Hello fellow M1 Hyper users! 👋

Chiming in to say, xattr -rd com.apple.quarantine also worked for me. I have never used that command before so I didn't know what it was doing or how to use it, so if you're like me here is some more info:

Run the full command xattr -rd com.apple.quarantine ~/Downloads/Hyper-3.1.0-canary.4-mac-arm64.dmg (except wherever the dmg path actually is) in your normal M1 Terminal and then double click the dmg afterwards to install.

What the command is doing is removing the "extended attribute" of com.apple.quarantine which you may have run into before when trying to open apps downloaded off the internet, and it says it's from an unrecognised developer and you have to go into system preferences to tick a box and allow it to open, etc etc etc. This is just a way of doing that on the command line. -d says to delete the quarantine extended attribute; -r is for recursive.

If you get an error like zsh: command not found: xattr -rd try typing out the full command above from scratch - I copy pasted the first time and for some reason it didn't work.

@psyrendust
Copy link

Is there a download link for the latest canary m1 build?

@LabhanshAgrawal
Copy link
Collaborator

Is there a download link for the latest canary m1 build?

https://github.com/vercel/hyper/actions/runs/766491280#artifacts

@psyrendust
Copy link

Thank you! Using xattr -rd com.apple.quarantine Hyper-3.1.0-canary.4-mac-arm64.dmg worked with no issues. FYI I've been using this free menubar app Silicon Info to see what architecture an app is using.

@tonymihut
Copy link

Building from source on node 16 worked for me, tyvm 🚀🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests