Weird characters showing since upgrade to 3.1.0

[corneliusroemer]

• I am on the latest Hyper.app version
• I have searched the issues of this repo and believe that this is not a duplicate

• OS version and name: Ubuntu 20.04
• Hyper.app version: 3.1.0
• Link of a Gist with the contents of your .hyper.js: Vanilla
• The issue is reproducible in vanilla Hyper.app: Yes

Issue

I updated and have some very weird characters appearing.

I use fish shell and fira code nf.

I downgraded to 3.0.2 again and it's fine now.

[corneliusroemer]

Other people seem to have the same problem: #5753 (comment)

[LabhanshAgrawal]

#5753 (reply in thread) mentions that removing ligatures plugin solved it.
You've written that you are using vanilla config, can you confirm again?

[corneliusroemer]

This is my config, the only change is that I now use "Fira Code NF" as font (which has ligatures). No plugin enabled.

https://gist.github.com/corneliusroemer/9783395f7793aa8b79ea6c08a7dd6380

[pregnor]

I experience the same on macOS 11.4 (Big Sur, amd), Hyper 3.1.0, bash shell with Fira Code font (contains ligatures), .hyper.js [removed after resolution].

I don't have the font-ligatures plugin, but I do have other plugins installed, although IMO none of those should interfere with the shell display area.

[LabhanshAgrawal]

Looks like xterm ligatures plugin is not playing well with webgl renderer.
Can you all try setting

disableLigatures: true

and check if it's fixed.

P.S. If you want to use ligatures, you will have to use canvas renderer by setting webGLRenderer: false

[pregnor]

For me using either disableLigatures: true or webGLRenderer: false successfully fixes the issue. 👍

(Also not sure if it helps with anything, but the messed up text seems to be deterministic. I can reliably issue an ls -al command in my home directory and always have the same characters messed up when both ligatures and webGLRenderer are turned on.)

[LabhanshAgrawal]

I'll disable webgl and ligatures combination until it's fixed in xterm then.

[corneliusroemer]

Great, where/when can I test?

[LabhanshAgrawal]

Doing a patch release soon.

[corneliusroemer]

Just tested 3.1.1, looks good so far. Will close for now.

[gerdm]

Hi, I just downloaded version 3.1.1 and I still seem to have the same problem. Any suggestions?

I've also tried to set webGLRenderer: false, and disableLigatures: true

[corneliusroemer]

Ok, I reopen because of @gerdm's report. For me, it is fixed though (at least haven't seen any problems yet).

[LabhanshAgrawal]

@gerdm The about dialog is showing webgl as the renderer
you need to open a new window after disabling webgl
also you are using a plugin for ligatures which would enable the ligatures addon despite disabling it in the config.

[gerdm]

Hi @LabhanshAgrawal,

You're correct, I had a plugin that was using ligatures. Removing that plugin made everything work fine.
Thank you!