"1 week" returns undefined

[okor]

I would expect "1 week" to return a result.

> ~/Projects/voxmedia/tempo $ npm install ms
ms@0.7.0 node_modules/ms
~/Projects/voxmedia/tempo $ node
> var ms = require('ms')
undefined
> ms('5 minutes')
300000
> ms('15 minutes')
900000
> ms('2 hours')
7200000
> ms('2 hour')
7200000
> ms('2 h')
7200000
> ms('1 day')
86400000
> ms('1 week')
undefined
> ms('1 weeks')
undefined
> ms('1 month')
undefined
> ms('1 year')
31557600000

I would also expect "1 month" to return a result (though that one is slightly tricky) and sources seem to disagree.

^ I would probably just call it 30 days even and be done with it. Maybe include a note in the docs as to what the library considers 1 month.

Anyhow, weeks should probably work. Otherwise the lib is great. Thanks!

[okor]

And perhaps it would be appropriate to throw an Error if no result can be returned.

[havenchyk]

@okor If the problem still exists, PR is welcomed!

[LinusU]

I would recommend throwing an error, that is what I'm doing in parse-iso-duration.

throw new Error('Ambiguous duration')

[yvele]

The month unit is discussed in a dedicated issue: #57

[leo]

#57