Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add console output when minifying fails #648

Merged
merged 4 commits into from
Mar 11, 2021

Conversation

songkeys
Copy link
Contributor

@songkeys songkeys commented Feb 1, 2021

It took me quite a while to find that my output is not minified because there's a "formidable" dependency that causes this stage failing, not because I passed a wrong flag. I think there should be a console output to let users know the output is not minified because of failure.

@songkeys songkeys requested review from styfle and Timer as code owners February 1, 2021 04:05
src/index.js Outdated Show resolved Hide resolved
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle styfle added the automerge Automatically merge PR once checks pass label Mar 11, 2021
@styfle
Copy link
Member

styfle commented Mar 11, 2021

We probably just need to update terser to handle the case when its failing to minify.

Would you want to submit another PR to do that?

@kodiakhq kodiakhq bot merged commit bccd662 into vercel:master Mar 11, 2021
@songkeys
Copy link
Contributor Author

@styfle Sorry, no. I've moved to vercel/nft 😅. And I think a newer version cannot solve this issue either, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants