Remove Collecting build traces JS step

Author: mischnic

packages/next/src/build/collect-build-traces.ts

@@ -82,7 +82,6 @@ export async function collectBuildTraces({
   hasSsrAmpPages,
   buildTraceContext,
   outputFileTracingRoot,
-  isTurbopack,
 }: {
   dir: string
   distDir: string
@@ -94,7 +93,6 @@ export async function collectBuildTraces({
   nextBuildSpan?: Span
   config: NextConfigComplete
   buildTraceContext?: BuildTraceContext
-  isTurbopack: boolean
 }) {
   const startTime = Date.now()
   debug('starting build traces')
@@ -111,13 +109,11 @@ export async function collectBuildTraces({
     .traceAsyncFn(async () => {
       const nextServerTraceOutput = path.join(
         distDir,
-        isTurbopack ? 'next-server.ref.js.nft.json' : 'next-server.js.nft.json'
+        'next-server.js.nft.json'
       )
       const nextMinimalTraceOutput = path.join(
         distDir,
-        isTurbopack
-          ? 'next-minimal-server.ref.js.nft.json'
-          : 'next-minimal-server.js.nft.json'
+        'next-minimal-server.js.nft.json'
       )
       const root = outputFileTracingRoot
 
@@ -282,11 +278,6 @@ export async function collectBuildTraces({
         )
       }
 
-      if (isTurbopack) {
-        addToTracedFiles(distDir, './package.json', serverTracedFiles)
-        addToTracedFiles(distDir, './package.json', minimalServerTracedFiles)
-      }
-
       {
         const chunksToTrace: string[] = [
           ...(buildTraceContext?.chunksTrace?.action.input || []),

packages/next/src/build/index.ts

@@ -1736,7 +1736,6 @@ export default async function build(
                     hasSsrAmpPages: false,
                     buildTraceContext,
                     outputFileTracingRoot,
-                    isTurbopack: false,
                   })
                   .catch((err) => {
                     console.error(err)
@@ -2630,7 +2629,7 @@ export default async function build(
 
       await writeFunctionsConfigManifest(distDir, functionsConfigManifest)
 
-      if (!isGenerateMode && !buildTracesPromise) {
+      if (!isTurbopack && !isGenerateMode && !buildTracesPromise) {
         buildTracesPromise = collectBuildTraces({
           dir,
           config,
@@ -2641,7 +2640,6 @@ export default async function build(
           hasSsrAmpPages,
           buildTraceContext,
           outputFileTracingRoot,
-          isTurbopack,
         }).catch((err) => {
           console.error(err)
           process.exit(1)
@@ -3923,7 +3921,10 @@ export default async function build(
       }
 
       const postBuildSpinner = createSpinner('Finalizing page optimization')
-      let buildTracesSpinner = createSpinner(`Collecting build traces`)
+      let buildTracesSpinner
+      if (buildTracesPromise) {
+        buildTracesSpinner = createSpinner('Collecting build traces')
+      }
 
       // ensure the worker is not left hanging
       worker.end()

test/production/app-dir/build-output-tree-view/build-output-tree-view.test.ts

@@ -74,15 +74,15 @@ describe('build-output-tree-view', () => {
 })
 
 function getTreeView(cliOutput: string): string {
-  let foundBuildTracesLine = false
+  let foundStart = false
   const lines: string[] = []
 
   for (const line of cliOutput.split('\n')) {
-    if (foundBuildTracesLine) {
+    foundStart ||= line.startsWith('Route ')
+
+    if (foundStart) {
       lines.push(line)
     }
-
-    foundBuildTracesLine ||= line.includes('Collecting build traces')
   }
 
   return lines.join('\n').trim()