Skip to content

Commit 1400faa

Browse files
authored
Turbopack: bigger small value blocks (#82370)
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
1 parent 1fa24a4 commit 1400faa

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

turbopack/crates/turbo-persistence/src/static_sorted_file_builder.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,16 @@ use crate::{
1818
};
1919

2020
/// The maximum number of entries that should go into a single key block
21-
const MAX_KEY_BLOCK_ENTRIES: usize = 100 * 1024;
21+
const MAX_KEY_BLOCK_ENTRIES: usize = MAX_KEY_BLOCK_SIZE / KEY_BLOCK_ENTRY_META_OVERHEAD;
2222
/// The maximum bytes that should go into a single key block
2323
// Note this must fit into 3 bytes length
2424
const MAX_KEY_BLOCK_SIZE: usize = 16 * 1024;
2525
/// Overhead of bytes that should be counted for entries in a key block in addition to the key size
2626
const KEY_BLOCK_ENTRY_META_OVERHEAD: usize = 8;
2727
/// The maximum number of entries that should go into a single small value block
28-
const MAX_SMALL_VALUE_BLOCK_ENTRIES: usize = 100 * 1024;
28+
const MAX_SMALL_VALUE_BLOCK_ENTRIES: usize = MAX_SMALL_VALUE_BLOCK_SIZE;
2929
/// The maximum bytes that should go into a single small value block
30-
const MAX_SMALL_VALUE_BLOCK_SIZE: usize = 16 * 1024;
30+
const MAX_SMALL_VALUE_BLOCK_SIZE: usize = 64 * 1024;
3131
/// The aimed false positive rate for the AMQF
3232
const AMQF_FALSE_POSITIVE_RATE: f64 = 0.01;
3333

0 commit comments

Comments
 (0)