Improve Proxy invalid export error message

Author: devjiwonchoi

packages/next/src/build/analysis/get-page-static-info.ts

@@ -308,11 +308,11 @@ function validateMiddlewareProxyExports(ast: any, page: string): void {
 
   // Check if this is middleware/proxy
   const isMiddleware =
-    page.includes(`/${MIDDLEWARE_FILENAME}`) ||
-    page.includes(`/src/${MIDDLEWARE_FILENAME}`)
+    page === `/${MIDDLEWARE_FILENAME}` ||
+    page === `/src/${MIDDLEWARE_FILENAME}`
   const isProxy =
-    page.includes(`/${PROXY_FILENAME}`) ||
-    page.includes(`/src/${PROXY_FILENAME}`)
+    page === `/${PROXY_FILENAME}` ||
+    page === `/src/${PROXY_FILENAME}`
 
   if (!isMiddleware && !isProxy) {
     return // Not a middleware/proxy file, no validation needed
@@ -341,18 +341,6 @@ function validateMiddlewareProxyExports(ast: any, page: string): void {
         hasProxyExport = true
       }
     }
-    if (
-      node.type === 'ExportDeclaration' &&
-      node.declaration?.type === 'VariableDeclaration'
-    ) {
-      const declaration = node.declaration?.declarations[0]
-      if (declaration?.id.value === 'middleware') {
-        hasMiddlewareExport = true
-      }
-      if (declaration?.id.value === 'proxy') {
-        hasProxyExport = true
-      }
-    }
     if (node.type === 'ExportNamedDeclaration') {
       for (const specifier of node.specifiers) {
         if (
@@ -378,7 +366,16 @@ function validateMiddlewareProxyExports(ast: any, page: string): void {
 
   if (!hasValidExport) {
     throw new Error(
-      `The ${fileName === 'proxy' ? 'Proxy' : 'Middleware'} "${page}" must export a \`${fileName}\` or a \`default\` function`
+      `The file ${fileName} must export a function, either as a default export or as a named ${fileName} export.\n` +
+        `This function is what Next.js runs for every request handled by this ${fileName === 'proxy' ? 'proxy (previously called middleware)' : 'middleware'}.\n\n` +
+        `Why this happens:\n` +
+        `- The file exists but doesn't export a function.\n` +
+        `- The export is not a function (e.g., an object or constant).\n` +
+        `- There's a syntax error preventing the export from being recognized.\n\n` +
+        `To fix it:\n` +
+        `- Check your "${fileName}" file.\n` +
+        `- Ensure it has either a default or "${fileName}" function export.\n` +
+        `- Restart the dev server if the error persists.`
     )
   }
 }

packages/next/src/build/templates/middleware.ts

@@ -17,8 +17,21 @@ const isProxy = page === '/proxy' || page === '/src/proxy'
 const handler = (isProxy ? mod.proxy : mod.middleware) || mod.default
 
 if (typeof handler !== 'function') {
+  const fileName = isProxy ? 'proxy' : 'middleware'
+
   throw new Error(
-    `The ${isProxy ? 'Proxy' : 'Middleware'} "${page}" must export a ${isProxy ? '`proxy`' : '`middleware`'} or a \`default\` function`
+    `The file ${fileName} must export a function, either as a default export or as a named ${fileName} export.
+This function is what Next.js runs for every request handled by this ${fileName === 'proxy' ? 'proxy (previously called middleware)' : 'middleware'}.
+
+Why this happens:
+- The file exists but doesn't export a function.
+- The export is not a function (e.g., an object or constant).
+- There's a syntax error preventing the export from being recognized.
+
+To fix it:
+- Check your "${fileName}" file.
+- Ensure it has either a default or "${fileName}" function export.
+- Restart the dev server if the error persists.`
   )
 }