Skip to content

Commit 46369f5

Browse files
sokrajridgewell
andauthored
do not apply sass loader on existing loaders (#50308)
follow up for #50259 --------- Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
1 parent 06f505c commit 46369f5

File tree

1 file changed

+10
-5
lines changed
  • packages/next-swc/crates/next-core/src

1 file changed

+10
-5
lines changed

packages/next-swc/crates/next-core/src/sass.rs

+10-5
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,19 @@ pub async fn maybe_add_sass_loader(
3939
};
4040

4141
if let Some(rule) = rule {
42+
// Without `as`, loader result would be JS code, so we don't want to apply
43+
// sass-loader on that.
44+
let Some(rename_as) = rule.rename_as.as_ref() else {
45+
continue;
46+
};
47+
// Only when the result should run through the sass pipeline, we apply
48+
// sass-loader.
49+
if rename_as != "*" {
50+
continue;
51+
}
4252
let mut loaders = rule.loaders.await?.clone_value();
4353
loaders.push(loader);
4454
rule.loaders = WebpackLoaderItemsVc::cell(loaders);
45-
if let Some(rename_as) = rule.rename_as.as_mut() {
46-
rename_as.push_str(rename);
47-
} else {
48-
rule.rename_as = Some(format!("*{rename}"));
49-
}
5055
} else {
5156
rules.insert(
5257
pattern.to_string(),

0 commit comments

Comments
 (0)