Skip to content

Commit 7861621

Browse files
mischnicmischnic
authored
test: Refactor edge-runtime-dynamic-code test (#83390)
This test is about `eval` But it also used a non-static middleware `matchers` config, which is going to break once we are more strict about this and throw a build error.
1 parent c2d3e65 commit 7861621

File tree

4 files changed

+59
-55
lines changed

4 files changed

+59
-55
lines changed

‎test/integration/edge-runtime-dynamic-code/lib/utils.js‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,3 @@
1-
export const useCases = {
2-
eval: 'using-eval',
3-
noEval: 'not-using-eval',
4-
wasmCompile: 'using-webassembly-compile',
5-
wasmInstanciate: 'using-webassembly-instantiate',
6-
wasmBufferInstanciate: 'using-webassembly-instantiate-with-buffer',
7-
}
8-
91
export async function usingEval() {
102
// eslint-disable-next-line no-eval
113
return { value: eval('100') }

‎test/integration/edge-runtime-dynamic-code/middleware.js‎

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,39 @@
11
import { NextResponse } from 'next/server'
2-
import { useCases, notUsingEval, usingEval } from './lib/utils'
2+
import { notUsingEval, usingEval } from './lib/utils'
33
import {
44
usingWebAssemblyCompile,
55
usingWebAssemblyInstantiate,
66
usingWebAssemblyInstantiateWithBuffer,
77
} from './lib/wasm'
88

99
export async function middleware(request) {
10-
if (request.nextUrl.pathname === `/${useCases.eval}`) {
10+
if (request.nextUrl.pathname === '/using-eval') {
1111
return new Response(null, {
1212
headers: { data: JSON.stringify(await usingEval()) },
1313
})
1414
}
1515

16-
if (request.nextUrl.pathname === `/${useCases.noEval}`) {
16+
if (request.nextUrl.pathname === '/not-using-eval') {
1717
return new Response(null, {
1818
headers: { data: JSON.stringify(await notUsingEval()) },
1919
})
2020
}
2121

22-
if (request.nextUrl.pathname === `/${useCases.wasmCompile}`) {
22+
if (request.nextUrl.pathname === '/using-webassembly-compile') {
2323
return new Response(null, {
2424
headers: { data: JSON.stringify(await usingWebAssemblyCompile(9)) },
2525
})
2626
}
2727

28-
if (request.nextUrl.pathname === `/${useCases.wasmInstanciate}`) {
28+
if (request.nextUrl.pathname === '/using-webassembly-instantiate') {
2929
return new Response(null, {
3030
headers: { data: JSON.stringify(await usingWebAssemblyInstantiate(9)) },
3131
})
3232
}
3333

34-
if (request.nextUrl.pathname === `/${useCases.wasmBufferInstanciate}`) {
34+
if (
35+
request.nextUrl.pathname === '/using-webassembly-instantiate-with-buffer'
36+
) {
3537
return new Response(null, {
3638
headers: {
3739
data: JSON.stringify(await usingWebAssemblyInstantiateWithBuffer(9)),
@@ -43,5 +45,11 @@ export async function middleware(request) {
4345
}
4446

4547
export const config = {
46-
matcher: Object.values(useCases).map((route) => `/${route}`),
48+
matcher: [
49+
'/using-eval',
50+
'/not-using-eval',
51+
'/using-webassembly-compile',
52+
'/using-webassembly-instantiate',
53+
'/using-webassembly-instantiate-with-buffer',
54+
],
4755
}

‎test/integration/edge-runtime-dynamic-code/pages/api/route.js‎

Lines changed: 22 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { useCases, notUsingEval, usingEval } from '../../lib/utils'
1+
import { notUsingEval, usingEval } from '../../lib/utils'
22
import {
33
usingWebAssemblyCompile,
44
usingWebAssemblyInstantiate,
@@ -8,19 +8,27 @@ import {
88
export default async function handler(request) {
99
const useCase = request.nextUrl.searchParams.get('case')
1010

11-
return Response.json(
12-
useCase === useCases.eval
13-
? await usingEval()
14-
: useCase === useCases.noEval
15-
? await notUsingEval()
16-
: useCase === useCases.wasmCompile
17-
? await usingWebAssemblyCompile(9)
18-
: useCase === useCases.wasmInstanciate
19-
? await usingWebAssemblyInstantiate(9)
20-
: useCase === useCases.wasmBufferInstanciate
21-
? await usingWebAssemblyInstantiateWithBuffer(9)
22-
: { ok: true }
23-
)
11+
if (useCase === 'using-eval') {
12+
return Response.json(await usingEval())
13+
}
14+
15+
if (useCase === 'not-using-eval') {
16+
return Response.json(await notUsingEval())
17+
}
18+
19+
if (useCase === 'using-webassembly-compile') {
20+
return Response.json(await usingWebAssemblyCompile(9))
21+
}
22+
23+
if (useCase === 'using-webassembly-instantiate') {
24+
return Response.json(await usingWebAssemblyInstantiate(9))
25+
}
26+
27+
if (useCase === 'using-webassembly-instantiate-with-buffer') {
28+
return Response.json(await usingWebAssemblyInstantiateWithBuffer(9))
29+
}
30+
31+
return Response.json({ ok: true })
2432
}
2533

2634
export const config = { runtime: 'edge' }

‎test/integration/edge-runtime-dynamic-code/test/index.test.js‎

Lines changed: 22 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ describe('Page using eval in development mode', () => {
4242
beforeEach(() => (output = ''))
4343
afterAll(() => killApp(context.app))
4444

45-
it('does issue dynamic code evaluation warnings', async () => {
45+
it('does not issue dynamic code evaluation warnings', async () => {
4646
const html = await renderViaHTTP(context.appPort, '/')
4747
expect(html).toMatch(/>.*?100.*?and.*?100.*?<\//)
4848
await waitFor(500)
@@ -108,10 +108,10 @@ describe.each([
108108
isTurbopack
109109
? '' +
110110
// TODO(veil): Turbopack duplicates project path
111-
'\n at usingEval (../../test/integration/edge-runtime-dynamic-code/test/integration/edge-runtime-dynamic-code/lib/utils.js:11:17)' +
111+
'\n at usingEval (../../test/integration/edge-runtime-dynamic-code/test/integration/edge-runtime-dynamic-code/lib/utils.js:3:17)' +
112112
'\n at middleware (../../test/integration/edge-runtime-dynamic-code/test/integration/edge-runtime-dynamic-code/middleware.js:12:54)' +
113-
'\n 9 | export async function usingEval() {'
114-
: '\n at usingEval (../../test/integration/edge-runtime-dynamic-code/lib/utils.js:11:19)' +
113+
'\n 1 | export async function usingEval() {'
114+
: '\n at usingEval (../../test/integration/edge-runtime-dynamic-code/lib/utils.js:3:19)' +
115115
'\n at middleware (../../test/integration/edge-runtime-dynamic-code/middleware.js:12:54)' +
116116
// Next.js internal frame. Feel free to adjust.
117117
// Not ignore-listed because we're not in an isolated app and Next.js is symlinked so it's not in node_modules
@@ -122,27 +122,27 @@ describe.each([
122122
isTurbopack
123123
? '' +
124124
// TODO(veil): Turbopack duplicates project path
125-
'\n at usingEval (../../test/integration/edge-runtime-dynamic-code/test/integration/edge-runtime-dynamic-code/lib/utils.js:11:17)' +
126-
'\n at handler (../../test/integration/edge-runtime-dynamic-code/test/integration/edge-runtime-dynamic-code/pages/api/route.js:13:24)' +
127-
'\n 9 | export async function usingEval() {'
128-
: '\n at usingEval (../../test/integration/edge-runtime-dynamic-code/lib/utils.js:11:19)' +
129-
'\n at handler (../../test/integration/edge-runtime-dynamic-code/pages/api/route.js:13:24)' +
130-
'\n 9 | export async function usingEval() {'
125+
'\n at usingEval (../../test/integration/edge-runtime-dynamic-code/test/integration/edge-runtime-dynamic-code/lib/utils.js:3:17)' +
126+
'\n at handler (../../test/integration/edge-runtime-dynamic-code/test/integration/edge-runtime-dynamic-code/pages/api/route.js:12:41)' +
127+
'\n 1 | export async function usingEval() {'
128+
: '\n at usingEval (../../test/integration/edge-runtime-dynamic-code/lib/utils.js:3:19)' +
129+
'\n at handler (../../test/integration/edge-runtime-dynamic-code/pages/api/route.js:12:41)' +
130+
'\n 1 | export async function usingEval() {'
131131
)
132132
}
133133

134134
// Turbopack produces incorrect mappings in the sourcemap.
135135
if (isTurbopack) {
136136
expect(output).toContain(
137137
'' +
138-
"\n> 11 | return { value: eval('100') }" +
139-
'\n | ^'
138+
"\n> 3 | return { value: eval('100') }" +
139+
'\n | ^'
140140
)
141141
} else {
142142
expect(output).toContain(
143143
'' +
144-
"\n> 11 | return { value: eval('100') }" +
145-
'\n | ^'
144+
"\n> 3 | return { value: eval('100') }" +
145+
'\n | ^'
146146
)
147147
}
148148
})
@@ -189,14 +189,12 @@ describe.each([
189189
? '' +
190190
// TODO(veil): Turbopack duplicates project path
191191
'\n at usingWebAssemblyCompile (../../test/integration/edge-runtime-dynamic-code/test/integration/edge-runtime-dynamic-code/lib/wasm.js:22:18)' +
192-
'\n at handler (../../test/integration/edge-runtime-dynamic-code/test/integration/edge-runtime-dynamic-code/pages/api/route.js:17:42)' +
192+
'\n at handler (../../test/integration/edge-runtime-dynamic-code/test/integration/edge-runtime-dynamic-code/pages/api/route.js:20:55)' +
193193
'\n 20 |'
194194
: '' +
195195
'\n at usingWebAssemblyCompile (../../test/integration/edge-runtime-dynamic-code/lib/wasm.js:22:24)' +
196-
'\n at handler (../../test/integration/edge-runtime-dynamic-code/pages/api/route.js:17:42)' +
197-
// Next.js internal frame. Feel free to adjust.
198-
// Not ignore-listed because we're not in an isolated app and Next.js is symlinked so it's not in node_modules
199-
'\n at'
196+
'\n at handler (../../test/integration/edge-runtime-dynamic-code/pages/api/route.js:20:55)' +
197+
'\n 20 |'
200198
)
201199

202200
// Turbopack produces incorrect mappings in the sourcemap.
@@ -230,11 +228,11 @@ describe.each([
230228
isTurbopack
231229
? '' +
232230
'\n at async usingWebAssemblyInstantiateWithBuffer (../../test/integration/edge-runtime-dynamic-code/test/integration/edge-runtime-dynamic-code/lib/wasm.js:28:24)' +
233-
'\n at async middleware (../../test/integration/edge-runtime-dynamic-code/test/integration/edge-runtime-dynamic-code/middleware.js:37:30)' +
231+
'\n at async middleware (../../test/integration/edge-runtime-dynamic-code/test/integration/edge-runtime-dynamic-code/middleware.js:39:30)' +
234232
'\n 26 |\n'
235233
: '' +
236234
'\n at async usingWebAssemblyInstantiateWithBuffer (../../test/integration/edge-runtime-dynamic-code/lib/wasm.js:28:24)' +
237-
'\n at async middleware (../../test/integration/edge-runtime-dynamic-code/middleware.js:37:30)' +
235+
'\n at async middleware (../../test/integration/edge-runtime-dynamic-code/middleware.js:39:30)' +
238236
// Next.js internal frame. Feel free to adjust.
239237
// TODO(veil): https://linear.app/vercel/issue/NDX-464
240238
'\n at '
@@ -250,14 +248,12 @@ describe.each([
250248
? '' +
251249
// TODO(veil): Turbopack duplicates project path
252250
'\n at async usingWebAssemblyInstantiateWithBuffer (../../test/integration/edge-runtime-dynamic-code/test/integration/edge-runtime-dynamic-code/lib/wasm.js:28:24)' +
253-
'\n at async handler (../../test/integration/edge-runtime-dynamic-code/test/integration/edge-runtime-dynamic-code/pages/api/route.js:21:17)' +
251+
'\n at async handler (../../test/integration/edge-runtime-dynamic-code/test/integration/edge-runtime-dynamic-code/pages/api/route.js:28:26)' +
254252
'\n 26 |'
255253
: '' +
256254
'\n at async usingWebAssemblyInstantiateWithBuffer (../../test/integration/edge-runtime-dynamic-code/lib/wasm.js:28:24)' +
257-
'\n at async handler (../../test/integration/edge-runtime-dynamic-code/pages/api/route.js:21:17)' +
258-
// Next.js internal frame. Feel free to adjust.
259-
// Not ignore-listed because we're not in an isolated app and Next.js is symlinked so it's not in node_modules
260-
'\n at'
255+
'\n at async handler (../../test/integration/edge-runtime-dynamic-code/pages/api/route.js:28:26)' +
256+
'\n 26 |'
261257
)
262258
// TODO(veil): Inconsistent cursor position
263259
expect(stripAnsi(output)).toContain(

0 commit comments

Comments
 (0)