Skip to content

Commit bb12617

Browse files
committed
tweak test for Azure (#64424)
Looks like the `useTempDir` function throws when running in Azure rather than piping the message to stderr. This makes the test resilient to both cases. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Closes NEXT-3095
1 parent 1b55577 commit bb12617

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

test/integration/create-next-app/index.test.ts

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@ describe('create-next-app', () => {
3131
})
3232

3333
it('should not create if the target directory is not writable', async () => {
34+
const expectedErrorMessage =
35+
/you do not have write permissions for this folder|EPERM: operation not permitted/
36+
3437
await useTempDir(async (cwd) => {
3538
const projectName = 'dir-not-writable'
3639

@@ -45,6 +48,7 @@ describe('create-next-app', () => {
4548
)
4649
return
4750
}
51+
4852
const res = await run(
4953
[
5054
projectName,
@@ -61,10 +65,12 @@ describe('create-next-app', () => {
6165
}
6266
)
6367

64-
expect(res.stderr).toMatch(
65-
/you do not have write permissions for this folder/
66-
)
68+
expect(res.stderr).toMatch(expectedErrorMessage)
6769
expect(res.exitCode).toBe(1)
68-
}, 0o500)
70+
}, 0o500).catch((err) => {
71+
if (!expectedErrorMessage.test(err.message)) {
72+
throw err
73+
}
74+
})
6975
})
7076
})

0 commit comments

Comments
 (0)