[dynamicIO] log dynamic validation errors consistently in dev

In dev when dynamicIO is enabled we performa a validating prerender to look for code that would be a build error in `next build`. However due to the construction of the earlier implementation of this code some validation messages were being suprressed because they were conveyed as a thrown error rather than through console.error. This change updates the mechanism by which we raise these issues in dev so they are consistently messaged.

Author: gnoff

packages/next/src/server/app-render/dynamic-rendering.ts

@@ -691,8 +691,9 @@ export function throwIfDisallowedEmptyStaticShell(
   // you need to opt into that by adding a Suspense boundary above the body
   // to indicate your are ok with fully dynamic rendering.
   if (dynamicValidation.hasDynamicViewport) {
-    throw new StaticGenBailoutError(
+    console.error(
       `Route "${route}" has a \`generateViewport\` that depends on Request data (\`cookies()\`, etc...) or uncached external data (\`fetch(...)\`, etc...) without explicitly allowing fully dynamic rendering. See more info here: https://nextjs.org/docs/messages/next-prerender-dynamic-viewport`
     )
+    throw new StaticGenBailoutError()
   }
 }

test/e2e/app-dir/dynamic-io-errors/fixtures/dynamic-metadata-dynamic-route/app/page.tsx

@@ -9,10 +9,9 @@ export default async function Page() {
   return (
     <>
       <p>
-        This page is static except for generateMetadata which does some IO. This
-        is a build error because metadata is not wrapped in a Suspense boundary.
-        We expect that if you intended for your metadata to be dynamic you will
-        ensure your page is dynamic too
+        This page has dynamic content and generateMetadata is also dynamic.
+        generateMetadata being dynamic in this context is fine because it isn't
+        the only reason the page is dynamic.
       </p>
       <Suspense fallback={<Fallback />}>
         <Dynamic />