Skip to content

Commit d57671c

Browse files
committed
tweak a few comments
1 parent a9f08ad commit d57671c

File tree

4 files changed

+5
-0
lines changed

4 files changed

+5
-0
lines changed

turbopack/crates/turbopack-browser/src/ecmascript/content.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,8 @@ impl VersionedContent for EcmascriptBrowserChunkContent {
149149
rope_builder.concat(code.source_code());
150150
rope_builder.push_static_bytes(b"\n");
151151
// Add debug ID comment if enabled
152+
// There is no point in attaching the debug ID if there is no source map so we only do
153+
// it conditionally.
152154
if let Some(debug_id) = &*self.code().debug_id().await? {
153155
write!(rope_builder, "\n//# debugId={}", debug_id)?;
154156
}

turbopack/crates/turbopack-css/src/chunk/mod.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ impl CssChunk {
7474
.reference_chunk_source_maps(Vc::upcast(self))
7575
.await?;
7676

77+
// CSS chunks never have debug IDs
7778
let mut code = CodeBuilder::new(source_maps, false);
7879
let mut body = CodeBuilder::new(source_maps, false);
7980
let mut external_imports = FxIndexSet::default();

turbopack/crates/turbopack-css/src/chunk/single_item_chunk/chunk.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ impl SingleItemCssChunk {
5353
.chunking_context
5454
.reference_chunk_source_maps(Vc::upcast(self))
5555
.await?;
56+
// CSS chunks never have debug IDs
5657
let mut code = CodeBuilder::new(source_maps, false);
5758

5859
if matches!(

turbopack/crates/turbopack-ecmascript/src/minify.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ use crate::parse::generate_js_source_map;
3434

3535
#[instrument(level = "info", name = "minify ecmascript code", skip_all)]
3636
pub fn minify(code: Code, source_maps: bool, mangle: Option<MangleType>) -> Result<Code> {
37+
// Pass None for the debug ID so we don't needlessly compute it for the pre-minified content.
3738
let source_maps = source_maps.then(|| code.generate_source_map_ref(None));
3839

3940
let generate_debug_id = code.generate_debug_id();

0 commit comments

Comments
 (0)