Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration between server and client hot-reloading #1012

Closed
sedubois opened this issue Feb 6, 2017 · 4 comments
Closed

Integration between server and client hot-reloading #1012

sedubois opened this issue Feb 6, 2017 · 4 comments

Comments

@sedubois
Copy link
Contributor

sedubois commented Feb 6, 2017

Projects with custom server (like my own: https://github.com/relatenow/relate), where nodemon is used to hot-reload server changes, don't fare well when changing code on both the server and the client, especially simultaneously. In that case, hot-reloading might get stuck and never recover:

DONE  Compiled successfully in 3764ms

[nodemon] restarting due to changes...
WAIT  Compiling...

DONE  Compiled successfully in 2160ms

The above message might lead to think that reloading is complete, but actually there's no confirmation message from nodemon, only from Next. Nodemon is stuck for some reason.

Also the messages are different when the server or the client reloads ([nodemon] restarting due to changes... in the former case, and WAIT Compiling... in the latter).

I don't see an obvious way to fix this, but thought would report it to draw attention to the fact that it's quite cumbersome nevertheless (need to restart server manually in these cases).

@Angel200O
Copy link

I am using babel-watch instead of nodemon for hot-reloading with a custom server

This is what i run

"watch": "node_modules/.bin/babel-watch -w database -w routes -w server.js -w util.js --disable-autowatch server.js"

So far its working pretty well, just make sure to add the folders you want to be watching that next isn't watching

@jesseditson
Copy link
Contributor

Hey! Curious (and optimistic) about this being closed - is there a solution for this use case in the works?

@timneutkens
Copy link
Member

timneutkens commented Nov 12, 2017

@jesseditson closed because the issue has been inactive for more than 9 months, and we're having the #1388 issue there already 👍

@jesseditson
Copy link
Contributor

Fair enough! Would love to see some progress over on #1388 but understand how much work it is to maintain this stuff. Happy to help where needed if the team has time for review over there!

@lock lock bot locked as resolved and limited conversation to collaborators May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants