Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start testing Fiber #1098

Closed
rauchg opened this issue Feb 13, 2017 · 17 comments
Closed

Start testing Fiber #1098

rauchg opened this issue Feb 13, 2017 · 17 comments

Comments

@rauchg
Copy link
Member

rauchg commented Feb 13, 2017

react@16.0.0-alpha.2
react-dom@16.0.0-alpha.2

We'll need to use the following:
require('react-dom/fiber')

@rauchg
Copy link
Member Author

rauchg commented Feb 13, 2017

Here's an example on how to opt into low priority updates:
https://github.com/facebook/react/blob/master/examples/fiber/index.html#L136

@ravikiran438
Copy link

React 16 Beta is out now for public testing.

facebook/react#10294

@sergiodxa
Copy link
Contributor

I just tried Next.js with React 16 Beta and it throw this error.

image

It looks like Next.js is using a internal lib and React 16 doesn't expose them anymore.

@gaearon
Copy link
Contributor

gaearon commented Jul 26, 2017

Yes, nothing in /lib/ will be exposed in 16. Happy to discuss specific use cases for internals in facebook/react#10294.

@arunoda
Copy link
Contributor

arunoda commented Jul 27, 2017

@gaearon Thanks.
We've a PR for this: https://github.com/zeit/next.js/pull/2570/files

Basically we want to track errors happening inside the component.
In the ^^ above PR, is uses some method in Fiber.

Is that the way we should do it?

@arunoda
Copy link
Contributor

arunoda commented Jul 27, 2017

@gaearon I started it here: #2659
Let me know I'm doing it good here.

@gaearon
Copy link
Contributor

gaearon commented Jul 27, 2017

Seems reasonable to me.
Note that this isn’t supported on server side yet (but normal catch works there).

@arunoda
Copy link
Contributor

arunoda commented Jul 27, 2017

Yeah! I got that. (Actually, that's good in a sense)
We've already catch errors on the server. So, I hope we are good to go.

@jamonholmgren
Copy link

This also happens when trying to switch to Preact (and using the example provided).

 ERROR  Failed to compile with 1 errors                                                                                      7:40:58 PM

This module was not found:

* react-dom/lib/ReactReconciler in ./~/next/dist/client/next-dev.js

To install it, you can run: npm install --save react-dom/lib/ReactReconciler
> Ready on http://localhost:3000

@dmbaranov
Copy link

So React 16 is out now, any updates about it? Because I still have an error:

* react-dom/lib/ReactReconciler in ../node_modules/next/dist/client/next-dev.js

To install it, you can run: npm install --save react-dom/lib/ReactReconciler

@bntzio
Copy link

bntzio commented Sep 27, 2017

Yeah me too @dmt-13

@jesseditson
Copy link
Contributor

@dmt-13 and @bntzio : as per latest README (not sure when it was updated), you'll either need to use next@beta to use react 16+, or if you want to use stable next, install react and react-dom @15 (npm i next react@15 react-dom@15 or npm i next@beta react react-dom)

@bntzio
Copy link

bntzio commented Oct 2, 2017

Yep, I just got it working, you need:

  • react@16.0.0
  • react-dom@16.0.0
  • next@4.0.0-beta.2

@damusnet
Copy link
Contributor

damusnet commented Oct 3, 2017

FYI, I just tried to update our app from Next.js 2.0 / React 15 to Next.js 4.0 / React 16, and except for a few warnings related to SSR / Client rehydration (on very edge cases, not critical at all), everything worked perfectly!

So, thank you to all contributors, this is amazing!

@timneutkens
Copy link
Member

@damusnet great to hear ❤️ Closing this ticket 👍

@brendonco
Copy link

@timneutkens Have you tried in IE11?

@lock
Copy link

lock bot commented May 10, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests