Fix index revalidate with dynamic route in minimal mode

[ijjk]

This fixes the case where index page revalidation would match a dynamic page instead of the index page from the pathname not being denormalized.

Fixes: #22750

[ijjk]

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js fix/index-dynamic-revalidate	Change
buildDuration	10.8s	10.5s	-266ms
nodeModulesSize	42.8 MB	42.8 MB	⚠️ +453 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js fix/index-dynamic-revalidate	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.046	2.003	-0.04
/ avg req/sec	1221.85	1248.02	+26.17
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.344	1.373	⚠️ +0.03
/error-in-render avg req/sec	1859.5	1821.43	⚠️ -38.07

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js fix/index-dynamic-revalidate	Change
677f882d2ed8..e7a0.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.65 kB	6.65 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.7 kB	59.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/index-dynamic-revalidate	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/index-dynamic-revalidate	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/index-dynamic-revalidate	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js fix/index-dynamic-revalidate	Change
index.html gzip	613 B	613 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	609 B	609 B	✓
Overall change	1.84 kB	1.84 kB	✓

---

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js fix/index-dynamic-revalidate	Change
buildDuration	12.9s	12.7s	-202ms
nodeModulesSize	42.8 MB	42.8 MB	⚠️ +453 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js fix/index-dynamic-revalidate	Change
677f882d2ed8..e7a0.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.65 kB	6.65 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.7 kB	59.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/index-dynamic-revalidate	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/index-dynamic-revalidate	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/index-dynamic-revalidate	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Serverless bundles

	vercel/next.js canary	ijjk/next.js fix/index-dynamic-revalidate	Change
_error.js	1.02 MB	1.02 MB	✓
404.html	2.67 kB	2.67 kB	✓
500.html	2.65 kB	2.65 kB	✓
amp.amp.html	10.5 kB	10.5 kB	✓
amp.html	1.86 kB	1.86 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1.02 MB	1.02 MB	✓
link.js	1.08 MB	1.08 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.27 MB	5.27 MB	✓

---

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js fix/index-dynamic-revalidate	Change
buildDuration	12.9s	12.8s	-140ms
nodeModulesSize	42.8 MB	42.8 MB	⚠️ +453 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js fix/index-dynamic-revalidate	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.971	1.965	-0.01
/ avg req/sec	1268.56	1271.99	+3.43
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.395	1.37	-0.02
/error-in-render avg req/sec	1791.78	1825.39	+33.61

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js fix/index-dynamic-revalidate	Change
597-74632e79..1d47.js gzip	13.3 kB	13.3 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.6 kB	6.6 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	60.1 kB	60.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/index-dynamic-revalidate	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/index-dynamic-revalidate	Change
_app-aedc815..1421.js gzip	1.26 kB	1.26 kB	✓
_error-71ec2..1a96.js gzip	3.38 kB	3.38 kB	✓
amp-33a09cb0..6745.js gzip	536 B	536 B	✓
hooks-4e968a..f870.js gzip	902 B	902 B	✓
index-5c6845..f75c.js gzip	230 B	230 B	✓
link-99f0c6c..b84a.js gzip	1.65 kB	1.65 kB	✓
routerDirect..bb56.js gzip	306 B	306 B	✓
withRouter-7..2133.js gzip	302 B	302 B	✓
Overall change	8.57 kB	8.57 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/index-dynamic-revalidate	Change
_buildManifest.js gzip	326 B	326 B	✓
Overall change	326 B	326 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js fix/index-dynamic-revalidate	Change
index.html gzip	586 B	586 B	✓
link.html gzip	593 B	593 B	✓
withRouter.html gzip	582 B	582 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "RBXabWsHPsjUDFmjnP16Z",
+        "buildId": "dCnsKw58ZJlmAjZbsEXpo",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/RBXabWsHPsjUDFmjnP16Z/_buildManifest.js"
+      src="/_next/static/dCnsKw58ZJlmAjZbsEXpo/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/RBXabWsHPsjUDFmjnP16Z/_ssgManifest.js"
+      src="/_next/static/dCnsKw58ZJlmAjZbsEXpo/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "RBXabWsHPsjUDFmjnP16Z",
+        "buildId": "dCnsKw58ZJlmAjZbsEXpo",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/RBXabWsHPsjUDFmjnP16Z/_buildManifest.js"
+      src="/_next/static/dCnsKw58ZJlmAjZbsEXpo/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/RBXabWsHPsjUDFmjnP16Z/_ssgManifest.js"
+      src="/_next/static/dCnsKw58ZJlmAjZbsEXpo/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "RBXabWsHPsjUDFmjnP16Z",
+        "buildId": "dCnsKw58ZJlmAjZbsEXpo",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/RBXabWsHPsjUDFmjnP16Z/_buildManifest.js"
+      src="/_next/static/dCnsKw58ZJlmAjZbsEXpo/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/RBXabWsHPsjUDFmjnP16Z/_ssgManifest.js"
+      src="/_next/static/dCnsKw58ZJlmAjZbsEXpo/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 1fcbf2e

[zetoke]

Hey @ijjk !
Just curious. Why did you change enableWorkerThreads value to false? Why not use the native worker_threads? Or does it require a separate process by using child_process lib?

[ijjk]

@zetoke the worker threads option was disabled here since it would fail when some native dependencies like sharp are required.

[zetoke]

@ijjk ahhh, got it. Thanks a lot for the explanation!