Ensure env is loaded before next config #22879

ijjk · 2021-03-08T16:30:50Z

This ensures we load all env values before loading next.config.js since these values can be used in there. This also updates to ensure we're testing these values are available while loading next.config.js so we don't regress on this.

Fixes: #22811
Fixes: #22843

packages/next/next-server/server/config-utils.ts

ijjk · 2021-03-08T16:42:25Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js update/env-loading	Change
buildDuration	13s	12.6s	-332ms
nodeModulesSize	42.8 MB	42.8 MB	⚠️ +1.65 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js update/env-loading	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.337	2.284	-0.05
/ avg req/sec	1069.82	1094.75	+24.93
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.582	1.513	-0.07
/error-in-render avg req/sec	1580.06	1652.27	+72.21

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js update/env-loading	Change
677f882d2ed8..a2e7.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.65 kB	6.65 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js update/env-loading	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js update/env-loading	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js update/env-loading	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js update/env-loading	Change
index.html gzip	615 B	615 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	609 B	609 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js update/env-loading	Change
buildDuration	15.2s	14.2s	-1s
nodeModulesSize	42.8 MB	42.8 MB	⚠️ +1.65 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js update/env-loading	Change
677f882d2ed8..a2e7.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.65 kB	6.65 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js update/env-loading	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js update/env-loading	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js update/env-loading	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Serverless bundles

	vercel/next.js canary	ijjk/next.js update/env-loading	Change
_error.js	1.02 MB	1.02 MB	✓
404.html	2.67 kB	2.67 kB	✓
500.html	2.65 kB	2.65 kB	✓
amp.amp.html	10.5 kB	10.5 kB	✓
amp.html	1.86 kB	1.86 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1.02 MB	1.02 MB	✓
link.js	1.08 MB	1.08 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.27 MB	5.27 MB	✓

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js update/env-loading	Change
buildDuration	15.2s	14s	-1.2s
nodeModulesSize	42.8 MB	42.8 MB	⚠️ +1.65 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js update/env-loading	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.355	2.219	-0.14
/ avg req/sec	1061.77	1126.57	+64.8
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.594	1.446	-0.15
/error-in-render avg req/sec	1568.36	1729.5	+161.14

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js update/env-loading	Change
597-2bc2376a..203d.js gzip	13.3 kB	13.3 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	60.2 kB	60.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js update/env-loading	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js update/env-loading	Change
_app-aedc815..1421.js gzip	1.26 kB	1.26 kB	✓
_error-71ec2..1a96.js gzip	3.38 kB	3.38 kB	✓
amp-33a09cb0..6745.js gzip	536 B	536 B	✓
hooks-4e968a..f870.js gzip	902 B	902 B	✓
index-5c6845..f75c.js gzip	230 B	230 B	✓
link-99f0c6c..b84a.js gzip	1.65 kB	1.65 kB	✓
routerDirect..bb56.js gzip	306 B	306 B	✓
withRouter-7..2133.js gzip	302 B	302 B	✓
Overall change	8.57 kB	8.57 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js update/env-loading	Change
_buildManifest.js gzip	326 B	326 B	✓
Overall change	326 B	326 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js update/env-loading	Change
index.html gzip	586 B	586 B	✓
link.html gzip	592 B	592 B	✓
withRouter.html gzip	580 B	580 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "CjN_0SkxkBnrQZF5rYOl8",
+        "buildId": "OMyCD-ntzlHKcMG02XW9l",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/CjN_0SkxkBnrQZF5rYOl8/_buildManifest.js"
+      src="/_next/static/OMyCD-ntzlHKcMG02XW9l/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/CjN_0SkxkBnrQZF5rYOl8/_ssgManifest.js"
+      src="/_next/static/OMyCD-ntzlHKcMG02XW9l/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "CjN_0SkxkBnrQZF5rYOl8",
+        "buildId": "OMyCD-ntzlHKcMG02XW9l",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/CjN_0SkxkBnrQZF5rYOl8/_buildManifest.js"
+      src="/_next/static/OMyCD-ntzlHKcMG02XW9l/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/CjN_0SkxkBnrQZF5rYOl8/_ssgManifest.js"
+      src="/_next/static/OMyCD-ntzlHKcMG02XW9l/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "CjN_0SkxkBnrQZF5rYOl8",
+        "buildId": "OMyCD-ntzlHKcMG02XW9l",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/CjN_0SkxkBnrQZF5rYOl8/_buildManifest.js"
+      src="/_next/static/OMyCD-ntzlHKcMG02XW9l/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/CjN_0SkxkBnrQZF5rYOl8/_ssgManifest.js"
+      src="/_next/static/OMyCD-ntzlHKcMG02XW9l/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 932a530

lipoolock · 2021-03-09T21:57:45Z

Hi @ijjk @timneutkens

I think it remains an issue with env variable and test environment
I setup a reproducible example here https://codesandbox.io/s/laughing-leaf-zfp7k?file=/__tests__/testing-library.js

If you run yarn test __tests__/testing-library.js you will get undefined instead of fooBar for the env variable set in .env.test

ijjk · 2021-03-10T16:29:50Z

@lipoolock I responded on the issue you created here this doesn't appear to be a bug related to env loading in Next.js

ijjk added 2 commits March 8, 2021 10:29

Ensure env is loaded before next config

0900be0

Merge remote-tracking branch 'upstream/canary' into update/env-loading

932a530

ijjk requested review from divmain, lfades, Timer and timneutkens as code owners March 8, 2021 16:30

ijjk added the type: next label Mar 8, 2021

timneutkens reviewed Mar 8, 2021

View reviewed changes

packages/next/next-server/server/config-utils.ts Show resolved Hide resolved

ijjk requested a review from timneutkens March 8, 2021 16:44

timneutkens approved these changes Mar 8, 2021

View reviewed changes

kodiakhq bot merged commit e950677 into vercel:canary Mar 8, 2021

ijjk deleted the update/env-loading branch March 8, 2021 16:57

matamatanot mentioned this pull request Mar 8, 2021

Env variables from .env* file don't expose to next.config.* anymore #22881

Closed

timneutkens mentioned this pull request Mar 9, 2021

process.env vars are no longer accessible in next.config.js in development mode #22896

Closed

jnv mentioned this pull request Mar 10, 2021

error building with latest preact, next.js: Cannot find module 'webpack' preactjs/next-plugin-preact#18

Closed

snyk-bot mentioned this pull request Jan 12, 2022

[Snyk] Upgrade three from 0.128.0 to 0.135.0 adamlaska/next.js#66

Open

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure env is loaded before next config #22879

Ensure env is loaded before next config #22879

ijjk commented Mar 8, 2021 •

edited

Loading

ijjk commented Mar 8, 2021

Diffs

lipoolock commented Mar 9, 2021

ijjk commented Mar 10, 2021

Ensure env is loaded before next config #22879

Ensure env is loaded before next config #22879

Conversation

ijjk commented Mar 8, 2021 • edited Loading

ijjk commented Mar 8, 2021

Stats from current PR

Diffs

lipoolock commented Mar 9, 2021

ijjk commented Mar 10, 2021

ijjk commented Mar 8, 2021 •

edited

Loading