Update /500 page exporting when _error has custom GIP

[ijjk]

This updates to not automatically export /500 from _error if a custom getInitialProps is used since logic may be used inside of this method that causes the export to fail. Users can still opt-in to the static /500 by adding a pages/500.js file.

This also refactors checking _app for custom getInitialProps to outside of the static check loop to prevent a potential race condition where we could run this check multiple times un-necessarily.

Fixes: #22815

[ijjk]

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js update/500-exporting	Change
buildDuration	11.4s	11.6s	⚠️ +174ms
nodeModulesSize	42.8 MB	42.8 MB	⚠️ +309 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js update/500-exporting	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.982	2.016	⚠️ +0.03
/ avg req/sec	1261.48	1239.94	⚠️ -21.54
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.282	1.249	-0.03
/error-in-render avg req/sec	1950.27	2002.27	+52

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js update/500-exporting	Change
677f882d2ed8..a2e7.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.65 kB	6.65 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js update/500-exporting	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js update/500-exporting	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js update/500-exporting	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js update/500-exporting	Change
index.html gzip	614 B	614 B	✓
link.html gzip	622 B	622 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

---

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js update/500-exporting	Change
buildDuration	13.9s	13.2s	-608ms
nodeModulesSize	42.8 MB	42.8 MB	⚠️ +309 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js update/500-exporting	Change
677f882d2ed8..a2e7.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.65 kB	6.65 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js update/500-exporting	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js update/500-exporting	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js update/500-exporting	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Serverless bundles

	vercel/next.js canary	ijjk/next.js update/500-exporting	Change
_error.js	1.02 MB	1.02 MB	✓
404.html	2.67 kB	2.67 kB	✓
500.html	2.65 kB	2.65 kB	✓
amp.amp.html	10.5 kB	10.5 kB	✓
amp.html	1.86 kB	1.86 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1.02 MB	1.02 MB	✓
link.js	1.08 MB	1.08 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.27 MB	5.27 MB	✓

---

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js update/500-exporting	Change
buildDuration	13.5s	13.3s	-239ms
nodeModulesSize	42.8 MB	42.8 MB	⚠️ +309 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js update/500-exporting	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.975	1.926	-0.05
/ avg req/sec	1265.8	1297.84	+32.04
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.24	1.229	-0.01
/error-in-render avg req/sec	2016.13	2034.79	+18.66

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js update/500-exporting	Change
597-2bc2376a..203d.js gzip	13.3 kB	13.3 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	60.2 kB	60.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js update/500-exporting	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js update/500-exporting	Change
_app-aedc815..1421.js gzip	1.26 kB	1.26 kB	✓
_error-71ec2..1a96.js gzip	3.38 kB	3.38 kB	✓
amp-33a09cb0..6745.js gzip	536 B	536 B	✓
hooks-4e968a..f870.js gzip	902 B	902 B	✓
index-5c6845..f75c.js gzip	230 B	230 B	✓
link-99f0c6c..b84a.js gzip	1.65 kB	1.65 kB	✓
routerDirect..bb56.js gzip	306 B	306 B	✓
withRouter-7..2133.js gzip	302 B	302 B	✓
Overall change	8.57 kB	8.57 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js update/500-exporting	Change
_buildManifest.js gzip	326 B	326 B	✓
Overall change	326 B	326 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js update/500-exporting	Change
index.html gzip	585 B	585 B	✓
link.html gzip	592 B	592 B	✓
withRouter.html gzip	581 B	581 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "ig9UngHUgZ1xmUYct7YdW",
+        "buildId": "_xpOMqJkros0ewCRTtBVO",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/ig9UngHUgZ1xmUYct7YdW/_buildManifest.js"
+      src="/_next/static/_xpOMqJkros0ewCRTtBVO/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/ig9UngHUgZ1xmUYct7YdW/_ssgManifest.js"
+      src="/_next/static/_xpOMqJkros0ewCRTtBVO/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "ig9UngHUgZ1xmUYct7YdW",
+        "buildId": "_xpOMqJkros0ewCRTtBVO",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/ig9UngHUgZ1xmUYct7YdW/_buildManifest.js"
+      src="/_next/static/_xpOMqJkros0ewCRTtBVO/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/ig9UngHUgZ1xmUYct7YdW/_ssgManifest.js"
+      src="/_next/static/_xpOMqJkros0ewCRTtBVO/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "ig9UngHUgZ1xmUYct7YdW",
+        "buildId": "_xpOMqJkros0ewCRTtBVO",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/ig9UngHUgZ1xmUYct7YdW/_buildManifest.js"
+      src="/_next/static/_xpOMqJkros0ewCRTtBVO/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/ig9UngHUgZ1xmUYct7YdW/_ssgManifest.js"
+      src="/_next/static/_xpOMqJkros0ewCRTtBVO/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 1d46d7e