Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[a11y] Route Announcements" #23082

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Revert "[a11y] Route Announcements" #23082

merged 1 commit into from
Mar 15, 2021

Conversation

shuding
Copy link
Member

@shuding shuding commented Mar 15, 2021

Reverts #20428 temporarily to move this feature into the next canary release.

@ijjk
Copy link
Member

ijjk commented Mar 15, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js revert-20428-client-nav-a11y Change
buildDuration 11.4s 11.3s -85ms
nodeModulesSize 42.8 MB 42.8 MB -8.22 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js revert-20428-client-nav-a11y Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.072 2.19 ⚠️ +0.12
/ avg req/sec 1206.75 1141.39 ⚠️ -65.36
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.356 1.422 ⚠️ +0.07
/error-in-render avg req/sec 1843.09 1758.63 ⚠️ -84.46
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary vercel/next.js revert-20428-client-nav-a11y Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 6.67 kB -464 B
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 59.8 kB -464 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js revert-20428-client-nav-a11y Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages Overall increase ⚠️
vercel/next.js canary vercel/next.js revert-20428-client-nav-a11y Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.67 kB ⚠️ +24 B
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.66 kB ⚠️ +24 B
Client Build Manifests Overall increase ⚠️
vercel/next.js canary vercel/next.js revert-20428-client-nav-a11y Change
_buildManifest.js gzip 346 B 347 B ⚠️ +1 B
Overall change 346 B 347 B ⚠️ +1 B
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary vercel/next.js revert-20428-client-nav-a11y Change
index.html gzip 613 B 613 B ✓
link.html gzip 621 B 619 B -2 B
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB -2 B

Diffs

Diff for _buildManifest.js 
@@ -8,7 +8,7 @@ self.__BUILD_MANIFEST = {
   "/hooks": [
     "static\u002Fchunks\u002Fpages\u002Fhooks-1c83fdb5c77614f18817.js"
   ],
-  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-e82300e7287385add1b5.js"],
+  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-3d75e6578a827afdc3f9.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-d1f18fd0349b020a8f6c.js"
   ],
Diff for link-e82300e..385add1b5.js 
@@ -145,6 +145,13 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
           shallow: shallow,
           locale: locale,
           scroll: scroll
+        }).then(function(success) {
+          if (!success) return;
+
+          if (scroll) {
+            // FIXME: proper route announcing at Router level, not Link:
+            document.body.focus();
+          }
         });
       }
Diff for main-HASH.js 
@@ -83,55 +83,6 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
       /***/
     },
 
-    /***/ CQWR: /***/ function(module, exports, __webpack_require__) {
-      "use strict";
-
-      var _slicedToArray = __webpack_require__("J4zp");
-
-      var _interopRequireWildcard = __webpack_require__("284h");
-
-      exports.__esModule = true;
-      exports.Portal = void 0;
-
-      var React = _interopRequireWildcard(__webpack_require__("q1tI"));
-
-      var _reactDom = __webpack_require__("i8i4");
-
-      var Portal = function Portal(_ref) {
-        var children = _ref.children,
-          type = _ref.type;
-        var portalNode = React.useRef(null);
-
-        var _React$useState = React.useState(),
-          _React$useState2 = _slicedToArray(_React$useState, 2),
-          forceUpdate = _React$useState2[1];
-
-        React.useEffect(
-          function() {
-            portalNode.current = document.createElement(type);
-            document.body.appendChild(portalNode.current);
-            forceUpdate({});
-            return function() {
-              if (portalNode.current) {
-                document.body.removeChild(portalNode.current);
-              }
-            };
-          },
-          [type]
-        );
-        return portalNode.current
-          ? /*#__PURE__*/ (0, _reactDom.createPortal)(
-              children,
-              portalNode.current
-            )
-          : null;
-      };
-
-      exports.Portal = Portal;
-
-      /***/
-    },
-
     /***/ DqTX: /***/ function(module, exports, __webpack_require__) {
       "use strict";
 
@@ -389,8 +340,6 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
 
       var _utils = __webpack_require__("g/15");
 
-      var _portal = __webpack_require__("CQWR");
-
       var _headManager = _interopRequireDefault(__webpack_require__("DqTX"));
 
       var _pageLoader = _interopRequireDefault(__webpack_require__("zmvN"));
@@ -399,8 +348,6 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
         __webpack_require__("bGXG")
       );
 
-      var _routeAnnouncer = __webpack_require__("oAez");
-
       var _router2 = __webpack_require__("nOHt");
       /* global location */
 
@@ -1252,17 +1199,7 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
           /*#__PURE__*/ _react["default"].createElement(
             AppContainer,
             null,
-            /*#__PURE__*/ _react["default"].createElement(App, appProps),
-            /*#__PURE__*/ _react["default"].createElement(
-              _portal.Portal,
-              {
-                type: "next-route-announcer"
-              },
-              /*#__PURE__*/ _react["default"].createElement(
-                _routeAnnouncer.RouteAnnouncer,
-                null
-              )
-            )
+            /*#__PURE__*/ _react["default"].createElement(App, appProps)
           )
         );
 
@@ -1422,92 +1359,6 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
       /***/
     },
 
-    /***/ oAez: /***/ function(module, exports, __webpack_require__) {
-      "use strict";
-
-      var _slicedToArray = __webpack_require__("J4zp");
-
-      var _interopRequireWildcard = __webpack_require__("284h");
-
-      exports.__esModule = true;
-      exports.RouteAnnouncer = RouteAnnouncer;
-      exports["default"] = void 0;
-
-      var _react = _interopRequireWildcard(__webpack_require__("q1tI"));
-
-      var _router = __webpack_require__("nOHt");
-
-      function RouteAnnouncer() {
-        var _ref = (0, _router.useRouter)(),
-          asPath = _ref.asPath;
-
-        var _ref2 = (0, _react.useState)(""),
-          _ref3 = _slicedToArray(_ref2, 2),
-          routeAnnouncement = _ref3[0],
-          setRouteAnnouncement = _ref3[1]; // Only announce the path change, but not for the first load because screen reader will do that automatically.
-
-        var initialPathLoaded = (0, _react.useRef)(false); // Every time the path changes, announce the route change. The announcement will be prioritized by h1, then title
-        // (from metadata), and finally if those don't exist, then the pathName that is in the URL. This methodology is
-        // inspired by Marcy Sutton's accessible client routing user testing. More information can be found here:
-        // https://www.gatsbyjs.com/blog/2019-07-11-user-testing-accessible-client-routing/
-
-        (0, _react.useEffect)(
-          function() {
-            if (!initialPathLoaded.current) {
-              initialPathLoaded.current = true;
-              return;
-            }
-
-            var newRouteAnnouncement;
-            var pageHeader = document.querySelector("h1");
-
-            if (pageHeader) {
-              newRouteAnnouncement =
-                pageHeader.innerText || pageHeader.textContent;
-            }
-
-            if (!newRouteAnnouncement) {
-              if (document.title) {
-                newRouteAnnouncement = document.title;
-              } else {
-                newRouteAnnouncement = asPath;
-              }
-            }
-
-            setRouteAnnouncement(newRouteAnnouncement);
-          }, // TODO: switch to pathname + query object of dynamic route requirements
-          [asPath]
-        );
-        return /*#__PURE__*/ _react["default"].createElement(
-          "p",
-          {
-            "aria-live": "assertive", // Make the announcement immediately.
-            id: "__next-route-announcer__",
-            role: "alert",
-            style: {
-              border: 0,
-              clip: "rect(0 0 0 0)",
-              height: "1px",
-              margin: "-1px",
-              overflow: "hidden",
-              padding: 0,
-              position: "absolute",
-              width: "1px",
-              // https://medium.com/@jessebeach/beware-smushed-off-screen-accessible-text-5952a4c2cbfe
-              whiteSpace: "nowrap",
-              wordWrap: "normal"
-            }
-          },
-          routeAnnouncement
-        );
-      }
-
-      var _default = RouteAnnouncer;
-      exports["default"] = _default;
-
-      /***/
-    },
-
     /***/ p0hA: /***/ function(module, exports, __webpack_require__) {
       /* WEBPACK VAR INJECTION */ (function(__dirname) {
         module.exports = (function() {
Diff for index.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-d0e6a2a9c7defb3386b2.js"
+      href="/_next/static/chunks/main-edb9c8fc083b6944d63c.js"
       as="script"
     />
     <link
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-020d2be99297a5eb71a0.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-d0e6a2a9c7defb3386b2.js"
+      src="/_next/static/chunks/main-edb9c8fc083b6944d63c.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-d0e6a2a9c7defb3386b2.js"
+      href="/_next/static/chunks/main-edb9c8fc083b6944d63c.js"
       as="script"
     />
     <link
@@ -32,7 +32,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/pages/link-e82300e7287385add1b5.js"
+      href="/_next/static/chunks/pages/link-3d75e6578a827afdc3f9.js"
       as="script"
     />
   </head>
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-020d2be99297a5eb71a0.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-d0e6a2a9c7defb3386b2.js"
+      src="/_next/static/chunks/main-edb9c8fc083b6944d63c.js"
       async=""
     ></script>
     <script
@@ -78,7 +78,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/link-e82300e7287385add1b5.js"
+      src="/_next/static/chunks/pages/link-3d75e6578a827afdc3f9.js"
       async=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""></script>
Diff for withRouter.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-d0e6a2a9c7defb3386b2.js"
+      href="/_next/static/chunks/main-edb9c8fc083b6944d63c.js"
       as="script"
     />
     <link
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-020d2be99297a5eb71a0.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-d0e6a2a9c7defb3386b2.js"
+      src="/_next/static/chunks/main-edb9c8fc083b6944d63c.js"
       async=""
     ></script>
     <script
Serverless Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js revert-20428-client-nav-a11y Change
buildDuration 13.8s 13.5s -346ms
nodeModulesSize 42.8 MB 42.8 MB -8.22 kB
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary vercel/next.js revert-20428-client-nav-a11y Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 6.67 kB -464 B
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 59.8 kB -464 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js revert-20428-client-nav-a11y Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages Overall increase ⚠️
vercel/next.js canary vercel/next.js revert-20428-client-nav-a11y Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB N/A N/A
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
link-c0d2c96..de48.js gzip N/A 1.67 kB N/A
Overall change 8.64 kB 8.66 kB ⚠️ +24 B
Client Build Manifests Overall increase ⚠️
vercel/next.js canary vercel/next.js revert-20428-client-nav-a11y Change
_buildManifest.js gzip 346 B 347 B ⚠️ +1 B
Overall change 346 B 347 B ⚠️ +1 B
Serverless bundles Overall increase ⚠️
vercel/next.js canary vercel/next.js revert-20428-client-nav-a11y Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ⚠️ +170 B
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ⚠️ +170 B
Webpack 5 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js revert-20428-client-nav-a11y Change
buildDuration 13.7s 14.4s ⚠️ +697ms
nodeModulesSize 42.8 MB 42.8 MB -8.22 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js revert-20428-client-nav-a11y Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.14 2.204 ⚠️ +0.06
/ avg req/sec 1168.15 1134.19 ⚠️ -33.96
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.562 1.481 -0.08
/error-in-render avg req/sec 1600.67 1688.09 +87.42
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary vercel/next.js revert-20428-client-nav-a11y Change
597-2bc2376a..203d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 7.08 kB 6.62 kB -462 B
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.7 kB 60.2 kB -462 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js revert-20428-client-nav-a11y Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages Overall increase ⚠️
vercel/next.js canary vercel/next.js revert-20428-client-nav-a11y Change
_app-0c62a59..94b7.js gzip 1.26 kB 1.26 kB ✓
_error-97d24..ed28.js gzip 3.38 kB 3.38 kB ✓
amp-2926e4c2..9ccc.js gzip 536 B 536 B ✓
hooks-1ed65b..8908.js gzip 902 B 902 B ✓
index-6259b6..77d8.js gzip 230 B 230 B ✓
link-2a29128..cc6e.js gzip 1.63 kB 1.65 kB ⚠️ +25 B
routerDirect..862a.js gzip 306 B 306 B ✓
withRouter-4..76fd.js gzip 302 B 302 B ✓
Overall change 8.54 kB 8.57 kB ⚠️ +25 B
Client Build Manifests
vercel/next.js canary vercel/next.js revert-20428-client-nav-a11y Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary vercel/next.js revert-20428-client-nav-a11y Change
index.html gzip 585 B 586 B ⚠️ +1 B
link.html gzip 593 B 593 B ✓
withRouter.html gzip 579 B 580 B ⚠️ +1 B
Overall change 1.76 kB 1.76 kB ⚠️ +2 B

Diffs

Diff for _buildManifest.js 
@@ -8,7 +8,7 @@ self.__BUILD_MANIFEST = {
   "/hooks": [
     "static\u002Fchunks\u002Fpages\u002Fhooks-107e903cc2136d5974c7.js"
   ],
-  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-e6cee42c996f3df349eb.js"],
+  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-c0d2c9648c4e376cde48.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-68414267e80493f2dc9d.js"
   ],
Diff for link-e6cee42..f3df349eb.js 
@@ -74,34 +74,34 @@ _N_E = (window.webpackJsonp_N_E = window.webpackJsonp_N_E || []).push([
           d = s.as,
           v = e.children,
           h = e.replace,
-          g = e.shallow,
-          y = e.scroll,
-          b = e.locale;
+          y = e.shallow,
+          b = e.scroll,
+          g = e.locale;
         "string" === typeof v && (v = a.default.createElement("a", null, v));
         var _ = a.Children.only(v),
-          w = _ && "object" === typeof _ && _.ref,
-          E = (0, i.useIntersection)({ rootMargin: "200px" }),
-          m = r(E, 2),
-          L = m[0],
-          M = m[1],
+          m = _ && "object" === typeof _ && _.ref,
+          w = (0, i.useIntersection)({ rootMargin: "200px" }),
+          E = r(w, 2),
+          L = E[0],
+          M = E[1],
           k = a.default.useCallback(
             function(e) {
               L(e),
-                w &&
-                  ("function" === typeof w
-                    ? w(e)
-                    : "object" === typeof w && (w.current = e));
+                m &&
+                  ("function" === typeof m
+                    ? m(e)
+                    : "object" === typeof m && (m.current = e));
             },
-            [w, L]
+            [m, L]
           );
         (0, a.useEffect)(
           function() {
             var e = M && n && (0, c.isLocalURL)(p),
-              r = "undefined" !== typeof b ? b : t && t.locale,
+              r = "undefined" !== typeof g ? g : t && t.locale,
               o = l[p + "%" + d + (r ? "%" + r : "")];
             e && !o && f(t, p, d, { locale: r });
           },
-          [d, p, M, b, n, t]
+          [d, p, M, g, n, t]
         );
         var I = {
           ref: k,
@@ -130,8 +130,10 @@ _N_E = (window.webpackJsonp_N_E = window.webpackJsonp_N_E || []).push([
                       shallow: a,
                       locale: i,
                       scroll: u
+                    }).then(function(e) {
+                      e && u && document.body.focus();
                     }));
-                })(e, t, p, d, h, g, y, b);
+                })(e, t, p, d, h, y, b, g);
           },
           onMouseEnter: function(e) {
             (0, c.isLocalURL)(p) &&
@@ -142,7 +144,7 @@ _N_E = (window.webpackJsonp_N_E = window.webpackJsonp_N_E || []).push([
           }
         };
         if (e.passHref || ("a" === _.type && !("href" in _.props))) {
-          var N = "undefined" !== typeof b ? b : t && t.locale,
+          var N = "undefined" !== typeof g ? g : t && t.locale,
             C =
               t &&
               t.isLocaleDomain &&
Diff for main-HASH.js

Diff too large to display

Diff for index.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-aa66340a481dcfd67451.js"
+      href="/_next/static/chunks/main-6a25d4da9580a5818bd7.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "CFlbRylYiG0QjS4tPRcSC",
+        "buildId": "HChnXp2Qel7xiMHTWn9-I",
         "isFallback": false,
         "gip": true
       }
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-ff94e68042added27a93.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa66340a481dcfd67451.js"
+      src="/_next/static/chunks/main-6a25d4da9580a5818bd7.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/CFlbRylYiG0QjS4tPRcSC/_buildManifest.js"
+      src="/_next/static/HChnXp2Qel7xiMHTWn9-I/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/CFlbRylYiG0QjS4tPRcSC/_ssgManifest.js"
+      src="/_next/static/HChnXp2Qel7xiMHTWn9-I/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-aa66340a481dcfd67451.js"
+      href="/_next/static/chunks/main-6a25d4da9580a5818bd7.js"
       as="script"
     />
     <link
@@ -32,7 +32,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/pages/link-e6cee42c996f3df349eb.js"
+      href="/_next/static/chunks/pages/link-c0d2c9648c4e376cde48.js"
       as="script"
     />
   </head>
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "CFlbRylYiG0QjS4tPRcSC",
+        "buildId": "HChnXp2Qel7xiMHTWn9-I",
         "isFallback": false,
         "gip": true
       }
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-ff94e68042added27a93.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa66340a481dcfd67451.js"
+      src="/_next/static/chunks/main-6a25d4da9580a5818bd7.js"
       async=""
     ></script>
     <script
@@ -78,15 +78,15 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/link-e6cee42c996f3df349eb.js"
+      src="/_next/static/chunks/pages/link-c0d2c9648c4e376cde48.js"
       async=""
     ></script>
     <script
-      src="/_next/static/CFlbRylYiG0QjS4tPRcSC/_buildManifest.js"
+      src="/_next/static/HChnXp2Qel7xiMHTWn9-I/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/CFlbRylYiG0QjS4tPRcSC/_ssgManifest.js"
+      src="/_next/static/HChnXp2Qel7xiMHTWn9-I/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-aa66340a481dcfd67451.js"
+      href="/_next/static/chunks/main-6a25d4da9580a5818bd7.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "CFlbRylYiG0QjS4tPRcSC",
+        "buildId": "HChnXp2Qel7xiMHTWn9-I",
         "isFallback": false,
         "gip": true
       }
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-ff94e68042added27a93.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa66340a481dcfd67451.js"
+      src="/_next/static/chunks/main-6a25d4da9580a5818bd7.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/CFlbRylYiG0QjS4tPRcSC/_buildManifest.js"
+      src="/_next/static/HChnXp2Qel7xiMHTWn9-I/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/CFlbRylYiG0QjS4tPRcSC/_ssgManifest.js"
+      src="/_next/static/HChnXp2Qel7xiMHTWn9-I/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 82416ce

@kodiakhq kodiakhq bot merged commit 732c49c into canary Mar 15, 2021
@kodiakhq kodiakhq bot deleted the revert-20428-client-nav-a11y branch March 15, 2021 19:09
shuding added a commit that referenced this pull request Mar 15, 2021
@shuding
Revert "Revert "[a11y] Route Announcements" (#23082)"
982b090 
This reverts commit 732c49c.
@shuding shuding mentioned this pull request Mar 15, 2021
Merged
This was referenced Mar 15, 2021
Merged
Closed
Closed
Closed
Merged
Merged
kodiakhq bot pushed a commit that referenced this pull request Mar 15, 2021
@shuding
Revert "Revert "[a11y] Route Announcements"" (#23086)
85499b5 
Reverts #23082
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
This was referenced Mar 16, 2021
Merged
Closed
Closed
Merged
Closed
Closed
Merged
Merged
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Merged
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Apr 29, 2021
@shuding
Revert "Revert "[a11y] Route Announcements"" (vercel#23086)
8af2015 
Reverts vercel#23082
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shuding @ijjk