Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UTF-8 charset by default to head #237

Closed
jimthedev opened this issue Nov 9, 2016 · 6 comments
Closed

Add UTF-8 charset by default to head #237

jimthedev opened this issue Nov 9, 2016 · 6 comments
Labels
good first issue Easy to fix issues, good for newcomers

Comments

@jimthedev
Copy link

Currently there is no charset added by default in the head. The problem is that if you don't have are charset and use a UTF-8 font like any of those in Google Fonts then you can easily run into this problem.

@nkzawa nkzawa added enhancement good first issue Easy to fix issues, good for newcomers labels Nov 11, 2016
@nkzawa
Copy link
Contributor

nkzawa commented Nov 13, 2016

SGTM

@nkzawa
Copy link
Contributor

nkzawa commented Nov 13, 2016

Related: #248

@rauchg
Copy link
Member

rauchg commented Nov 13, 2016

+1 as well

@rauchg
Copy link
Member

rauchg commented Nov 13, 2016

I'd still like to retain its customizability. We can basically have Head render a default utf-8 charset if none have been set. If <meta charSet> is passed, it overrides the default

@rauchg
Copy link
Member

rauchg commented Nov 14, 2016

Also, isn't this fixed by sending the right encoding with the HTTP response?

@mikecardwell
Copy link

@rauchg - HTTP response headers are OK until the user goes and saves the HTML page to disk. When they open the document later in the same or a different browser, it will not know the charset unless it is embedded in the document.

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Easy to fix issues, good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants