-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v12.1.5 regression with apollo client in SSR #36115
Comments
Thanks for raising this - got the same issue in tRPC. Repro:
ExpectedApp works without errors ActualApp has errors similar to the above Apollo-error on the server render. Try changing For the easy server-side rendering in tRPC/Apollo/urql we all rely on |
has anyone an idea what this could be? Usually this kind of error arises, when usages of apollo's |
Thanks for the repro, but for completeness, @macrozone could you also add one for your case? FWIW @KATT, I think |
Not sure if I can provide one in the next few hours or days. One important thing to know is, that its not about react 18. Its happening with react 17. conceptually my case is very similar to the one @KATT provided with his |
Official support, yes, but they have run their tests with react 18 for ages I made a better repro (which is using react 17 as well).
I've invited you as a contributor, @balazsorban44, so if you wanna test a new canary or something, feel free to open a new PR that runs through the E2E test suite. I wish I could provide an even better repro that didn't have libraries, but I really don't have time today.
|
Thank you, will have a look! |
Happened upon this myself in my Seems like the |
@KATT I have tested with |
@klarstrup just to double check: can this issue be closed then? |
It's @macrozone's issue, but I believe so yes |
Okay then I'll close it and @balazsorban44 can re-open if @macrozone is still running into it 👍 |
Confirmed fixed in KATT/next.js-issues-36115#4 |
thx guys, will check soon |
hope next@12.1.6 will come soon |
Thanks for the potential future fix! however, i had to downgrade to 3.4.17 due to apollographql/apollo-client#9456 The error msg then changed to |
This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Verify canary release
Provide environment information
What browser are you using? (if relevant)
No response
How are you deploying your application? (if relevant)
No response
Describe the Bug
we use the classic approach of doing ssr with @apollo/client where it runs getDataFromTree on the server and hydrates the client in a getInitialProps function.
when I upgraded next from 12.1.4 to 12.1.5 this broke:
Expected Behavior
this kind of setup should not be affected by a patch-release
To Reproduce
will try to provide later, i still need to gather information and try to find out which actual change is the root cause o this bug.
The text was updated successfully, but these errors were encountered: