Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dynamic] shouldn't loadingComponent just return null be default? #4058

Closed
rileybracken opened this issue Mar 26, 2018 · 2 comments
Closed

Comments

@rileybracken
Copy link

Currently if you are using next/dynamic it will return Loading... everywhere. I think that it should just return null by default that way you aren't forcing everyone to override Loading... (I assume everyone would). Instead if they want to create their own component they can. This would be super easy to do and I would be happy to add a PR for it.

Here is the line of code in question:
https://github.com/zeit/next.js/blob/canary/lib/dynamic.js#L32

@timneutkens
Copy link
Member

Fixed in #7543

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants