Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline story of the up-to-date detection logic #4711

Closed
oliviertassinari opened this issue Jul 1, 2018 · 1 comment · Fixed by #4639
Closed

Offline story of the up-to-date detection logic #4711

oliviertassinari opened this issue Jul 1, 2018 · 1 comment · Fixed by #4639

Comments

@oliviertassinari
Copy link
Contributor

Bug report

Describe the bug

I believe we miss the offline story of the up-to-date detection logic. I'm working in the train, with a Li-Fi connection (crappy).

If you are lucky, it fails fast with the following error:
capture d ecran 2018-07-01 a 19 58 35

However, if the connection lies to you (Li-Fi, it think it has internet but it doesn't) then you are stuck. The dev server refuses to start. He is waiting for a network request to complete.
After 1-2 minutes, you will get the following error:
capture d ecran 2018-07-01 a 19 51 53

To Reproduce

Steps to reproduce the behavior, please provide code snippets or a repository:

  1. Start the dev server without internet or with a fake internet connection
  2. See error

Expected behavior

I don't think that the up-to-date feature is important enough to harm offline development (we already have yarn oudated to solve this problem).

System information

  • Version of Next.js: 6.0.4-canary.8
@oliviertassinari
Copy link
Contributor Author

It's a win for the DX, thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant