Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style changes are not hot reloading #475

Closed
iamjacks opened this issue Dec 22, 2016 · 4 comments
Closed

Style changes are not hot reloading #475

iamjacks opened this issue Dec 22, 2016 · 4 comments
Assignees

Comments

@iamjacks
Copy link

iamjacks commented Dec 22, 2016

Trying out the 2.x beta using the same example styled-jsx code in the readme. Changing background: red to background: green results in all elements losing their styles. Refreshing restores them and displays the changes.

Edit: impronunciable mentioned below that styles are not being flushed. I'm noticing that as well. At first I thought it was related to using global, but it's not.

@impronunciable
Copy link
Contributor

A bigger issue that I spotted from here is that styles are not being flushed. If I change the background some times and then refresh I still get 4 style tags with previous styles even if those are not used anymore

screen shot 2016-12-22 at 8 29 03 am

@katopz
Copy link

katopz commented Dec 23, 2016

Same here (with some more issue) vercel/styled-jsx#50

@iamjacks
Copy link
Author

@rauchg npm is still listing 0.2.2 as the latest for styled-jsx

@rauchg
Copy link
Member

rauchg commented Dec 24, 2016

0.2.3 has been published

@lock lock bot locked as resolved and limited conversation to collaborators May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants