Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error styles not cleared, even after a refresh. #495

Closed
dnsco opened this issue Dec 23, 2016 · 4 comments
Closed

Error styles not cleared, even after a refresh. #495

dnsco opened this issue Dec 23, 2016 · 4 comments

Comments

@dnsco
Copy link

dnsco commented Dec 23, 2016

Hey, I'm on the 2.0 beta, after you generate an error, a burgundy background gets applied.

After you fix the error, the burgundy style is still there, below your content. Refreshing doesn't help, but restarting the server makes it go away.

Thanks for next! <3

@rauchg
Copy link
Member

rauchg commented Dec 23, 2016

Can you describe what error exactly you triggered @denniscollective ?

@dnsco
Copy link
Author

dnsco commented Dec 23, 2016

If I reference a nonexesitent component it renders this backtrace:

after I fix it (change back to , if I hard reset (#496), I see my content, but on top of a burgundy background.

ReferenceError: Headaa is not defined
    at Page.render (/Users/dennis/workspace/jarvo/pages/index.js?entry:30:10)
    at /Users/dennis/workspace/jarvo/node_modules/react-dom/lib/ReactCompositeComponent.js:796:21
    at measureLifeCyclePerf (/Users/dennis/workspace/jarvo/node_modules/react-dom/lib/ReactCompositeComponent.js:75:12)
    at null.ReactCompositeComponent._renderValidatedComponentWithoutOwnerOrContext (/Users/dennis/workspace/jarvo/node_modules/react-dom/lib/ReactCompositeComponent.js:795:25)
    at null.ReactCompositeComponent._renderValidatedComponent (/Users/dennis/workspace/jarvo/node_modules/react-dom/lib/ReactCompositeComponent.js:822:32)
    at null.ReactCompositeComponent.performInitialMount (/Users/dennis/workspace/jarvo/node_modules/react-dom/lib/ReactCompositeComponent.js:362:30)
    at null.ReactCompositeComponent.mountComponent (/Users/dennis/workspace/jarvo/node_modules/react-dom/lib/ReactCompositeComponent.js:258:21)
    at Object.ReactReconciler.mountComponent (/Users/dennis/workspace/jarvo/node_modules/react-dom/lib/ReactReconciler.js:46:35)
    at null.ReactCompositeComponent.performInitialMount (/Users/dennis/workspace/jarvo/node_modules/react-dom/lib/ReactCompositeComponent.js:371:34)
    at null.ReactCompositeComponent.mountComponent (/Users/dennis/workspace/jarvo/node_modules/react-dom/lib/ReactCompositeComponent.js:258:21)

@nkzawa
Copy link
Contributor

nkzawa commented Dec 24, 2016

This should be fixed on 2.0.0-beta.2.

@nkzawa nkzawa closed this as completed Dec 24, 2016
@dnsco
Copy link
Author

dnsco commented Dec 24, 2016

I've upgraded to 2.0.0-beta.2 but am still seeing some issues, they only surface when I refresh while the app is in a broken state, I put more detail on #496

@lock lock bot locked as resolved and limited conversation to collaborators May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants