Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript type checking #7114

Closed
timneutkens opened this issue Apr 23, 2019 · 5 comments
Closed

Add TypeScript type checking #7114

timneutkens opened this issue Apr 23, 2019 · 5 comments
Assignees
@Timer

Comments

@timneutkens
Copy link
Member

timneutkens commented Apr 23, 2019 •
edited by Timer
Loading

We'll probably have to do type checking and not just compilation. @Timer had some ideas for it.

Fixes #6466
@kachkaev
Copy link
Contributor

kachkaev commented Apr 23, 2019 •
edited
Loading

It'd be great if TypeScript errors did not block page compilation unless they are fatal. Problems like mismatching types are useful to see in the editor and when running yarn lint, however, if they crash page compilation in dev, that becomes quite annoying and blocks experimentation.

@ijjk ijjk mentioned this issue Apr 24, 2019
Merged
@isaachinman
Copy link
Contributor

I see @Timer closed #7125. What's the latest on this?

@Timer Timer closed this as completed May 8, 2019
@Timer
Copy link
Member

Timer commented May 8, 2019

This has been implemented!

@evenchange4 evenchange4 mentioned this issue May 28, 2019
Closed
@kachkaev kachkaev mentioned this issue Jun 27, 2019
Closed
@kachkaev
Copy link
Contributor

I created a new issue out of the comment above: #7687

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Timer Timer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kachkaev @Timer @timneutkens @isaachinman @balazsorban44