Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update sharp special case for pnpm #387

Merged
merged 7 commits into from
Feb 1, 2024
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jan 31, 2024

This ensures we trace child optional dependencies as well so that the symlink hierarchy is maintained for pnpm.

x-ref: vercel/next.js#59346
x-ref: lovell/sharp#3967

@ijjk ijjk requested a review from styfle as a code owner January 31, 2024 21:07
@ijjk ijjk changed the title Update sharp special case for pnpm fix: Update sharp special case for pnpm Jan 31, 2024
@ijjk ijjk changed the title fix: Update sharp special case for pnpm fix: update sharp special case for pnpm Jan 31, 2024
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we're running into a windows bug on node@18 so I had to skip it nodejs/node#18518

But all other platforms are passing, thanks! 🎉

@styfle styfle enabled auto-merge (squash) February 1, 2024 19:50
@styfle styfle merged commit d7fc336 into main Feb 1, 2024
12 checks passed
@styfle styfle deleted the ijjk/update-sharp-special-case branch February 1, 2024 20:00
Copy link

github-actions bot commented Feb 1, 2024

🎉 This PR is included in version 0.26.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants