-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(analyze): node-gyp-build not including zeromq prebuilds #392
fix(analyze): node-gyp-build not including zeromq prebuilds #392
Conversation
…evel where de require() is run at. Fixes zeromq.js. Closes vercel#391.
I will fix the test havoc ⛈️ |
@eulersson Thanks for making a fix. Let me know if there is anything to do on the Zeromq side. |
…tead log them as warnings to prevent user confusion.
…ttps://github.com/eulersson/nft into fix-node-gyp-build-not-including-zeromq-prebuilds
No problem. For now I do not think it will be needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks! 🎉
🎉 This PR is included in version 0.26.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
zeromq
#391Three things I want to point out:
path.join(__dirname, "..")
instead of__dirname
to therequire("node-gyp-build")(...)
call.@aminya/node-gyp-build
instead ofnode-gyp-build
, particular-li version4.5.0-aminya.5
.6
which is beta according to @aminya https://github.com/zeromq/zeromq.js.After those changes it resolves OK.