Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make semicolon optional? #103

Closed
ghost opened this issue Feb 3, 2017 · 4 comments
Closed

Make semicolon optional? #103

ghost opened this issue Feb 3, 2017 · 4 comments

Comments

@ghost
Copy link

ghost commented Feb 3, 2017

Since with ES6 and all of zeits packages it's become standard to not use the semicolon, wouldn't it be consistent to also apply this practise in the styled-jsx?

@giuseppeg
Copy link
Collaborator

We are not using semicolons in js. What do you mean?

@ghost
Copy link
Author

ghost commented Feb 3, 2017

<style jsx>{`
  .page-header {
    background-color: #000
    height: 60px
  }
`}</style>

instead of

<style jsx>{`
  .page-header {
    background-color: #000;
    height: 60px;
  }
`}</style>

@nkzawa
Copy link
Contributor

nkzawa commented Feb 3, 2017

Semicolon of css is not optional except last declarations in blocks.

@giuseppeg
Copy link
Collaborator

ditto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants