Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

${''} in new line will invalidate the whole css #235

Closed
ron-liu opened this issue Jun 9, 2017 · 2 comments
Closed

${''} in new line will invalidate the whole css #235

ron-liu opened this issue Jun 9, 2017 · 2 comments

Comments

@ron-liu
Copy link

ron-liu commented Jun 9, 2017

See the following example:

import css from './pp.js'
export default () => <div className="pp">
	<style jsx>{css}</style>
</div>)

pp.js

export default `
	.pp {
		background-color: red;
		width: 100px;
		height: 100px;
	}
        ${''} /* no matter what is put, even nothing like this one, it will cause the whole style-jsx invalid*/
`

The stranger thing is the following is valid

export default `
	.pp {
		background-color: red;
		width: 100px;
		height: 100px;

		border: blue ${'13px'} solid  /* this one works*/
	}
`

By the way, I am using next.js 3 beta11 with syled-jsx 1.0.4.

@giuseppeg
Copy link
Collaborator

I am fixing this in #227

@giuseppeg
Copy link
Collaborator

fixed in #227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants