Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load babel macro dynamically #812

Merged
merged 2 commits into from
Sep 5, 2022
Merged

fix: load babel macro dynamically #812

merged 2 commits into from
Sep 5, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Sep 5, 2022

Use require call to dynamic require macro plugins, so that it won't be bundled in the dist/babel assets when you're not using macro

  • chore: Upgrade bunchee to latest
  • test: create babel macro test module for testing

@huozhi huozhi force-pushed the fix/dynamic-require branch from 23553b8 to 9ff019d Compare September 5, 2022 17:21
@huozhi huozhi marked this pull request as ready for review September 5, 2022 17:21
@huozhi huozhi requested a review from ijjk as a code owner September 5, 2022 17:21
src/macro.js Outdated Show resolved Hide resolved
@huozhi huozhi marked this pull request as draft September 5, 2022 17:28
@huozhi huozhi marked this pull request as ready for review September 5, 2022 17:43
@huozhi huozhi requested a review from ijjk September 5, 2022 17:43
@huozhi huozhi changed the title fix: dynamic load babel macro as bundle fix:load babel macro dynamically Sep 5, 2022
@huozhi huozhi changed the title fix:load babel macro dynamically fix: load babel macro dynamically Sep 5, 2022
@huozhi huozhi merged commit 067fcd7 into main Sep 5, 2022
@huozhi huozhi deleted the fix/dynamic-require branch September 5, 2022 17:50
@github-actions
Copy link

github-actions bot commented Sep 5, 2022

🎉 This PR is included in version 5.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants