Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design system example does not proceed when prompt appears in npm dev script #1547

Closed
marr opened this issue Jul 16, 2022 · 2 comments
Closed
Assignees
Labels
area: examples Improvements or additions to examples

Comments

@marr
Copy link

marr commented Jul 16, 2022

What version of Turborepo are you using?

1.3.1

What package manager are you using / does the bug impact?

Yarn v1

What operating system are you using?

Mac

Describe the Bug

Following the install instructions for the design system example, I am not able to complete the dev script. There is a prompt in the script, since I already have port 6006 running which reads:

? Port 6006 is not available. Would you like to run Storybook on port 6007 instead? › (Y/n)

Pressing Enter does not complete the prompt, and the script waits. The storybook server is never started.

Expected Behavior

The prompt allows for interactivity
or
The "yes" option is selected automatically.

The first option may better for safety/security.

To Reproduce

  1. Have something listening on port 6006. You can run nc -l 6006 on a mac/linux machine in a separate terminal window to do this.
  2. Run the dev script after installing the design-system package. Install instructions
  3. See message from description prompting Y/n.
  4. No way to proceed after this.
@tknickman tknickman self-assigned this Jul 16, 2022
@tknickman tknickman added the area: examples Improvements or additions to examples label Jul 16, 2022
@marr
Copy link
Author

marr commented Jul 16, 2022

Related #1235

@anthonyshew
Copy link
Contributor

Closing as stale! Our recent example updates have this covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Improvements or additions to examples
Projects
None yet
Development

No branches or pull requests

4 participants