Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[turborepo] Concurrency option not ignored when Parallel execution flag is set #4438

Closed
nderscore opened this issue Apr 3, 2023 · 2 comments · Fixed by #5191
Closed

[turborepo] Concurrency option not ignored when Parallel execution flag is set #4438

nderscore opened this issue Apr 3, 2023 · 2 comments · Fixed by #5191
Labels
kind: bug Something isn't working

Comments

@nderscore
Copy link

nderscore commented Apr 3, 2023

What version of Turborepo are you using?

1.8.4 - 1.8.8

What package manager are you using / does the bug impact?

pnpm

What operating system are you using?

Mac

Describe the Bug

According to the docs, the --concurrency option will be ignored if the --parallel flag is also passed.

Since turborepo v1.8.4, this is no longer the behavior. Setting the --parallel CLI flag does not disable the --concurrency setting when a task is persistent.

In a project with more than 10 packages, the following error message is presented for a task with the option "persistent": true:

ERROR  run failed: error preparing engine: Invalid persistent task configuration:
You have {N} persistent tasks but `turbo` is configured for concurrency of 10. Set --concurrency to at least {N+1}

Expected Behavior

Setting --parallel should override the --concurrency option.

This was the existing behavior in turborepo v1.8.3

To Reproduce

Execute a --parallel task in a workspace with >10 packages and "persistent": true in the task's settings

Reproduction Repo

No response

@nderscore nderscore added area: turborepo kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage labels Apr 3, 2023
@mmachatschek
Copy link

We also bumped into this issue after migrating turbo from v1.7 to 1.9

@gsoltis
Copy link
Contributor

gsoltis commented Jun 2, 2023

Looks like we weren't checking for --parallel before doing some validation. I'll see if we can fix that quickly: #5191

@gsoltis gsoltis removed the needs: triage New issues get this label. Remove it after triage label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants