Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[turborepo] kitchen-sink invalid eslint configuration for api #5266

Closed
ph55 opened this issue Jun 11, 2023 · 0 comments · Fixed by #5892
Closed

[turborepo] kitchen-sink invalid eslint configuration for api #5266

ph55 opened this issue Jun 11, 2023 · 0 comments · Fixed by #5892
Assignees
Labels
kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage

Comments

@ph55
Copy link
Contributor

ph55 commented Jun 11, 2023

What version of Turborepo are you using?

1.10.3

What package manager are you using / does the bug impact?

pnpm

What operating system are you using?

Mac

Describe the Bug

eslint-config-custom-server is invalid and throws an typescript error on pnpm run lint

Expected Behavior

pnpm run lint should not throw an error and should work with typescript

To Reproduce

  • npx create-turbo -e kitchen-sink
  • cd kitchen-sink
  • edit apps/api/src/index.ts as following (add any type to port):
import { createServer } from "./server";
import { log } from "logger";

const port: any = process.env.PORT || 5001;
const server = createServer();

server.listen(port, () => {
  log(`api running on ${port}`);
});
  • pnpm run lint will throw an error:
api:lint:
api:lint: > api@0.0.0 lint /Users/alex/DevMe/kitchen-sinkek/apps/api
api:lint: > tsc --noEmit && eslint "src/**/*.ts*"
api:lint:
api:lint:
api:lint: /Users/alex/DevMe/kitchen-sinkek/apps/api/src/index.ts
api:lint:   4:11  error  Parsing error: Unexpected token :
api:lint:
api:lint: ✖ 1 problem (1 error, 0 warnings)
api:lint:
api:lint:  ELIFECYCLE  Command failed with exit code 1.
api:lint: ERROR: command finished with error: command (/Users/alex/devme/kitchen-sinkek/apps/api) pnpm run lint exited (1)
command (/Users/alex/devme/kitchen-sinkek/apps/api) pnpm run lint exited (1)

 Tasks:    6 successful, 7 total
Cached:    6 cached, 7 total
  Time:    4.312s
Failed:    api#lint

 ERROR  run failed: command  exited (1)
 ELIFECYCLE  Command failed with exit code 1.

Reproduction Repo

No response

@ph55 ph55 added area: turborepo kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage labels Jun 11, 2023
@tknickman tknickman self-assigned this Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants