Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take Node.js version into cache hash consideration #6201

Closed
gajus opened this issue Oct 18, 2023 · 1 comment
Closed

Take Node.js version into cache hash consideration #6201

gajus opened this issue Oct 18, 2023 · 1 comment
Labels
needs: triage New issues get this label. Remove it after triage

Comments

@gajus
Copy link

gajus commented Oct 18, 2023

Which project is this feature idea for?

Turborepo

Describe the feature you'd like to request

We discovered this while updating from Node.js v18 to v20.

I was surprised to see that tests were passing when I explicitly expected them to fail because of an update.

There are real issues of using Turbo cache in CI if it does not consider the Node.js version.

Describe the solution you'd like

Include Node.js version into the hash key.

Describe alternatives you've considered

N/A

@gajus gajus added needs: triage New issues get this label. Remove it after triage story labels Oct 18, 2023
@gajus
Copy link
Author

gajus commented Oct 18, 2023

Duplicate of #4124

@gajus gajus closed this as completed Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

No branches or pull requests

1 participant