Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keypress interaction with vite doesn't work ("o"+Enter doesn't open web) #8952

Closed
1 task done
shanike opened this issue Aug 6, 2024 · 2 comments
Closed
1 task done
Labels
kind: bug Something isn't working needs: author input

Comments

@shanike
Copy link

shanike commented Aug 6, 2024

Verify canary release

  • I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue

https://github.com/shanike/turborepo-bug-repro

What package manager are you using / does the bug impact?

pnpm

What operating system are you using?

Linux

Which canary version will you have in your reproduction?

2.0.12-canary.3

Describe the Bug

Hi! When using vite and turbo, the "tui" works nicely but has an annoying unexpected bug:
The part that works: The "gui" opens and runs as expected, and when pressing "Enter" on the persistent vite job, it focuses into it and allows typing.
The part afterwards which doesn't work: writing the letter "o" followed by an "Enter" -> nothing happens

Expected Behavior

When writing the letter "o" followed by an "Enter" in a vite job -> vite opens the localhost web on the correct job's port. This does not happen with v2 of turbo.

To Reproduce

  1. Install turbo
  2. On 1 app install vite
  3. Create a "dev" vite+turbo task
    Now,
  4. pnpm exec turbo dev on apps/apps-a
    will run vite with turbo and won't open the web when writing o + Enter
    But
  5. pnpm dev
    Will open the web when writing o + Enter

Additional context

On turbo v1.13.4 with experimentalUI turned on -> it DOES work: it opens the web when "interacting" with the vite task and pressing o + enter

@shanike shanike added kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage labels Aug 6, 2024
@chris-olszewski
Copy link
Member

A few questions:

  • Do any of the other commands work such as h + Enter showing help text?
  • Does pnpm exec turbo dev --env-mode=loose have different behavior?
  • Does open http://localhost:5173/ open the browser for you? (I think this is the command vite uses, but I could be wrong)

I wasn't able to reproduce so I'm wondering if this is Linux specific.
https://github.com/user-attachments/assets/040c9bc0-4928-4ade-a987-0f019691327c

@chris-olszewski chris-olszewski added needs: author input and removed needs: triage New issues get this label. Remove it after triage labels Aug 6, 2024
@chris-olszewski
Copy link
Member

Closing as there hasn't been any updates. Please reopen if you're still experiencing this issue!

@chris-olszewski chris-olszewski closed this as not planned Won't fix, can't repro, duplicate, stale Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working needs: author input
Projects
None yet
Development

No branches or pull requests

2 participants