refactor: use tanstack way for returning json

Author: adriandlam

workbench/tanstack/src/routes/api/hook.ts

@@ -1,4 +1,5 @@
 import { createFileRoute } from '@tanstack/react-router';
+import { json } from '@tanstack/react-start';
 import { getHookByToken, resumeHook } from 'workflow/api';
 
 export const Route = createFileRoute('/api/hook')({
@@ -14,8 +15,8 @@ export const Route = createFileRoute('/api/hook')({
         } catch (error) {
           console.log('error during getHookByToken', error);
           // TODO: `WorkflowAPIError` is not exported, so for now
-          // we'll return 404 assuming it's the "invalid" token test case
-          return Response.json(null, { status: 404 });
+          // we'll return 400 assuming it's the "invalid" token test case
+          return json(null, { status: 400 });
         }
 
         await resumeHook(hook.token, {
@@ -24,7 +25,7 @@ export const Route = createFileRoute('/api/hook')({
           customData: hook.metadata?.customData,
         });
 
-        return Response.json(hook);
+        return json(hook);
       },
     },
   },

workbench/tanstack/src/routes/api/signup.ts

@@ -1,4 +1,5 @@
 import { createFileRoute } from '@tanstack/react-router';
+import { json } from '@tanstack/react-start';
 import { start } from 'workflow/api';
 import { handleUserSignup } from 'workflows/user-signup';
 
@@ -7,7 +8,7 @@ export const Route = createFileRoute('/api/signup')({
     handlers: {
       GET: async ({ request }) => {
         const run = await start(handleUserSignup, ['test@example.com']);
-        return Response.json(run);
+        return json(run);
       },
     },
   },

workbench/tanstack/src/routes/api/trigger.ts

@@ -1,4 +1,5 @@
 import { createFileRoute } from '@tanstack/react-router';
+import { json } from '@tanstack/react-start';
 import { allWorkflows } from '_workflows.js';
 import { getRun, start } from 'workflow/api';
 import { hydrateWorkflowArguments } from 'workflow/internal/serialization';
@@ -49,7 +50,7 @@ export const Route = createFileRoute('/api/trigger')({
                   'Content-Type': 'application/octet-stream',
                 },
               })
-            : Response.json(returnValue);
+            : json(returnValue);
         } catch (error) {
           if (error instanceof Error) {
             if (error.name === 'WorkflowRunNotCompletedError') {

workbench/tanstack/vite.config.ts

@@ -18,11 +18,6 @@ const config = defineConfig({
     tanstackStart(),
     viteReact(),
   ],
-  build: {
-    commonjsOptions: {
-      transformMixedEsModules: true,
-    },
-  },
 });
 
 export default config;