Skip to content
This repository has been archived by the owner on Jun 16, 2024. It is now read-only.

fix: plugin type is not part of the name #21

Merged
merged 1 commit into from
Dec 26, 2019
Merged

Conversation

juanpicado
Copy link
Member

@juanpicado juanpicado commented Dec 26, 2019

If we use the plugin type as part of the name, then we must use the pluging type in the config.yaml and looks pretty odd

example:

currently

auth:
  htpasswd:
    file: ./htpasswd

without this fix

auth:
  auth-htpasswd:
    file: ./htpasswd

If we use the plugin type as part of the name, then we must use the pluging type in the config.yaml and looks pretty odd
Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@juanpicado juanpicado merged commit 8e69fa6 into master Dec 26, 2019
@juanpicado juanpicado deleted the fix-plugin-type branch December 26, 2019 20:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants