Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand test coverage for veres-one-validator when replacing MOCKPROOF #44

Open
4 tasks
aljones15 opened this issue Nov 17, 2021 · 0 comments
Open
4 tasks

Comments

@aljones15
Copy link
Contributor

We have tests for when the invocationTarget doesn't match, but we need tests for when you have the wrong root capability.

We need tests that hit this check in zcapld: https://github.com/digitalbazaar/zcapld/blob/e655ba0e67cbbf8d72467e7d650365bbe936a1c3/lib/utils.js#L522-L525

Also, we have no tests for the first proof in a record write operation because it is currently a MOCKPROOF.
When we remove the MOCKPROOF for a real ledgerWrite proof we need to also add a set of tests that ensure that ledgerWrites fail if

  • The invocationTarget has the wrong <incorrect-ledgerId>/records
  • The invocationTarget has a unknown path <ledgerId>/unknown
  • The capability id for the ledgerWrite proof is invalid capability: urn:zcap:invalid:foo
  • The capability id for the ledgerWrite proof refers to a non-existent ledger (this might succeed) urn:zcap:root:did:non:existent:ledger
@aljones15 aljones15 changed the title Expand test coverage for veres-one-validator Expand test coverage for veres-one-validator when replacing MOCKPROOF Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant