Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does MessageSerializer have to encode a dict only? #4

Open
mwong38 opened this issue May 15, 2016 · 0 comments
Open

Why does MessageSerializer have to encode a dict only? #4

mwong38 opened this issue May 15, 2016 · 0 comments

Comments

@mwong38
Copy link

mwong38 commented May 15, 2016

There are cases in a Kafka key, for example, that is a simple {"type": "string"} rather than a record. It would still be helpful to use the MessageSerializer. However, it doesn't permit non-dict's because of this check

        if not isinstance(record, dict):
            raise SerializerError("record must be a dictionary")

Any reason for this? Can it be removed?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant