Disconnected event does not deliver data object

[mariomurrent-softwaresolutions]

jssipInstance.on('disconnected', function(data) { // code here });

The data object is undefined. Concerning the documentation there should be at least socket, error, code and reason in the data object.

[ibc]

True. This happens due to this line in Transport.js:

https://github.com/versatica/JsSIP/blob/master/lib/Transport.js#L163

There we are calling disconnected without any data.

[mariomurrent-softwaresolutions]

Oh I see. I noticed it, because I was upgrading to the latest version. In the old version the disconnect event was called with data.

[jmillan]

True, the error data attribute should be there and should be set to false in this case, when the transport is closed by the user.

code and reason data attributes are optional and related to disconnection errors. They do not apply here.

http://jssip.net/documentation/3.2.x/api/socket/#event_ondisconnect

Thanks for reporting, I'll update it.

[ibc]

In fact, the payload of the disconnected event should be refactored. It assumes WebSocket, but that's just when we use the WebSocket transport.

[jmillan]

It assumes WebSocket, but that's just when we use the WebSocket transport.

Can you point it in the code?

[ibc]

Not in the code but in the doc: http://jssip.net/documentation/3.2.x/api/ua/#event_disconnected

[mariomurrent-softwaresolutions]

That's true. The documentation differs from the actual code.

[jmillan]

Not in the code but in the doc: http://jssip.net/documentation/3.2.x/api/ua/#event_disconnected

Aha, true. I'll synchronise it ASAP.

[mariomurrent-softwaresolutions]

So there will be no more parameters for the disconnect event?

[jmillan]

Those documented here: http://jssip.net/documentation/3.2.x/api/ua/#event_disconnected

[jmillan]

UA:disconnected event payload has been fixed for that case where it was empty.

After reviewing the doc I see that it's aligned with the implementation. Such event does not assume WebSocket, but Jssip:Socket instance.

[jmillan]

If there's any comment on this regard, please speak up.