Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTCSession.isReadyToReOffer method is undefined #807

Open
Abbyzhoum opened this issue Feb 10, 2023 · 4 comments
Open

RTCSession.isReadyToReOffer method is undefined #807

Abbyzhoum opened this issue Feb 10, 2023 · 4 comments

Comments

@Abbyzhoum
Copy link

When I use the isReadyToReOffer method to verify if it supports unhold call,I found that the isReadyToReOffer method does not exist.
I use _isReadyToReOffer is OK. Please check the issue,Thanks!

1676016967191

1676016612201

@PeteAUK
Copy link

PeteAUK commented Feb 23, 2023

Have you tried isReadyToReoffer without the underscore _?

@Abbyzhoum
Copy link
Author

I tried, look at the picture above

@tshi206
Copy link

tshi206 commented Jul 16, 2024

https://github.com/versatica/JsSIP/blob/master/lib/RTCSession.d.ts

The type definition is indeed inconsistent with the actual js class, it doesn't even define a isReadyToReOffer method, consider exposing it correctly as the official doc suggests

_isReadyToReOffer()

@tshi206
Copy link

tshi206 commented Jul 16, 2024

also https://github.com/versatica/JsSIP/blob/master/lib/JsSIP.d.ts#L13

it doesn't export Socket and WeightedSocket, please consider adjusting the d.ts by removing those two.

https://github.com/versatica/JsSIP/blob/master/lib/WebSocketInterface.js#L6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants