Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use runsc runtime path in OciManager::run_container #250

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

eureka-cpu
Copy link
Contributor

Instead of using a string for the command, "runsc", this will use the new environment variable or default path to a runsc binary.

@eureka-cpu eureka-cpu added the bug Something isn't working label Jul 18, 2024
@eureka-cpu eureka-cpu requested a review from andrewvious July 18, 2024 07:36
@eureka-cpu eureka-cpu self-assigned this Jul 18, 2024
@eureka-cpu eureka-cpu changed the title Use runsc runtime path in OciBundler Use runsc runtime path in OciManager::bundle Jul 18, 2024
@eureka-cpu eureka-cpu changed the title Use runsc runtime path in OciManager::bundle Use runsc runtime path in OciManager::run_container Jul 18, 2024
@eureka-cpu eureka-cpu merged commit 8be7018 into main Jul 18, 2024
4 checks passed
@eureka-cpu eureka-cpu deleted the eureka-cpu/use-runtime-path branch July 18, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants