-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: .tool-versions behavior #228
Comments
https://vfox.lhan.me/guides/quick-start.html#_5-switch-runtime
To be honest, I don't like this strategy. |
Just imagine you're in project, config |
The current |
Maybe we don't understand each other $ cd `mktemp -d`
$ mkdir -p proj/child
$ node -v # 20 for example
$ echo "nodejs 16.20.2" > proj/.tool-versions
$ vfox install nodejs@16.20.2
$ cd proj
$ node -v # 16 => its ok
$ cd child
$ node -v # 20 => its not ok => and this is unexpected behavior since another tools (asdf, nvmrc, pyenv...) always look at parent folder |
Okay, it can indeed be reproduced. |
@aooohan Your fix is not works if we go directly to child folder |
I'm aware of this, and for this issue, I need to make sure that the behavior I described earlier is correct. As I said earlier, I really don't like the strategy of keeping search up until reach Also, as for the situation you mentioned, I can't think of a case where it would go directly to a child folder of the project instead of the project root first. |
I think navigate to child directory is a common practice, particularly in monorepo projects. |
Describe the bug
The behavior of
asdf
will keep search up until reach/
https://github.com/asdf-vm/asdf/blob/ccdd47df9b73d0a22235eb06ad4c48eb57360832/lib/utils.bash#L212
While
vfox
just use config from current directoryThe text was updated successfully, but these errors were encountered: