Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] vfox config -l not all configurations shown #233

Closed
jan-bar opened this issue Apr 23, 2024 · 3 comments · Fixed by #234
Closed

[Question] vfox config -l not all configurations shown #233

jan-bar opened this issue Apr 23, 2024 · 3 comments · Fixed by #234
Labels
bug Something isn't working question Further information is requested

Comments

@jan-bar
Copy link
Contributor

jan-bar commented Apr 23, 2024

Currently viewing all configurations

vfox config -l

proxy.url = http://proxy.com:1080
proxy.enable = true
storage.sdkPath = D:\install
legacyVersionFile.enable = false

The configuration file content is as follows

proxy:
    url: http://proxy.com:1080
    enable: true
storage:
    sdkPath: D:\install
registry:
    address: ""
legacyVersionFile:
    enable: false

Here is the code that ignores the configuration: https://github.com/version-fox/vfox/blob/main/cmd/commands/config.go#L71-L74

Why should we ignore this type of configuration? registry.address = ""

If you don’t read the documentation and just execute the command, the user may not know this configuration.

@jan-bar jan-bar added the question Further information is requested label Apr 23, 2024
@aooohan
Copy link
Member

aooohan commented Apr 23, 2024

Why should we ignore this type of configuration? registry.address = ""

If you don’t read the documentation and just execute the command, the user may not know this configuration.

Indeed. I didn't notice this either. It should be displayed completely.

@aooohan aooohan added the bug Something isn't working label Apr 23, 2024
@Chance-fyi
Copy link
Member

I deliberately hid this. Considering that there might be many configurations in the future, I have hidden the unset configurations similar to git config --list.

@jan-bar
Copy link
Contributor Author

jan-bar commented Apr 23, 2024

I deliberately hid this. Considering that there might be many configurations in the future, I have hidden the unset configurations similar to git config --list.

After my testing, git config --list will still display the results when the value is an empty string.

image

It is also displayed normally when the value is not an empty string.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants