-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Creating a new terminal across the day cleans the temporary directory, causing the directory link in use to be deleted #283
Comments
This situation was never considered from the beginning. : | If we want to solve this issue, we have to see if the process is still alive as you suggested before we clean up. |
This solution needs to support cross-platform detection of whether the pid is running, which is not easy to implement. According to the above situation, when the terminal executes Add cross-day detection to the It is worth mentioning that fnm: Schniz/fnm#696 has not yet completed cleaning up the history files. |
This library can find the currently running process:https://github.com/mitchellh/go-ps |
Run |
Version
0.5.3
OS
Windows
Describe the bug
1716134400
->2024-05-20 00:00:00
,1716220800
->2024-05-21 00:00:00
The terminal created on
2024-05-20
never exitsCreate a new terminal on
2024-05-21
to trigger the temporary directory cleanup logicThen the temporary directory used by the terminal created on
2024-05-20
was deleted, and the temporary directory of2024-05-21
was generated. However, the terminal did not switch to the new temporary directory, and the corresponding temporary directory was not created directory linkThe text was updated successfully, but these errors were encountered: