Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion support for specific version manager files #47

Closed
pwall2222 opened this issue Feb 7, 2024 · 7 comments · Fixed by #188
Closed

Suggestion support for specific version manager files #47

pwall2222 opened this issue Feb 7, 2024 · 7 comments · Fixed by #188
Assignees
Labels
enhancement New feature or request

Comments

@pwall2222
Copy link

pwall2222 commented Feb 7, 2024

I have looked around in the docs but I have not found any mentions of this, but it would be a nice to add support for version managers files
Examples:

@aooohan
Copy link
Member

aooohan commented Feb 7, 2024

vfox has its own version management file, .tool-versions. It is the same as and compatible with asdf.

@aooohan
Copy link
Member

aooohan commented Feb 7, 2024

vfox will create a .tool-versions file to record SDK version you use when use vfox use -p <sdk-name> command.

@pwall2222
Copy link
Author

I did read that on the docs!
I just meant it would be a cool opt-in feature, as per the projects that use those files would remain "less" compatible with vfox

@aooohan
Copy link
Member

aooohan commented Feb 27, 2024

I did read that on the docs! I just meant it would be a cool opt-in feature, as per the projects that use those files would remain "less" compatible with vfox

Ok, I get what you meant now. To accomplish this, we need to add a new hook for the plugin, which is called when using the vfox use command.

@aooohan aooohan added the enhancement New feature or request label Feb 27, 2024
@pwall2222
Copy link
Author

That would be brilliant!

@ZuBB
Copy link

ZuBB commented Mar 9, 2024

I did read that on the docs! I just meant it would be a cool opt-in feature, as per the projects that use those files would remain "less" compatible with vfox

Ok, I get what you meant now. To accomplish this, we need to add a new hook for the plugin, which is called when using the vfox use command.

This would be great! Can we expect that .node-version also will be supported?

PS: I just discovered this package, and I am already in love with it!

@aooohan
Copy link
Member

aooohan commented Mar 9, 2024

I did read that on the docs! I just meant it would be a cool opt-in feature, as per the projects that use those files would remain "less" compatible with vfox

Ok, I get what you meant now. To accomplish this, we need to add a new hook for the plugin, which is called when using the vfox use command.

This would be great! Can we expect that .node-version also will be supported?

If .nvmrc is OK, then .node-version is totally OK! But it's just a work in progress.

PS: I just discovered this package, and I am already in love with it!

Thanks!

@aooohan aooohan self-assigned this Mar 14, 2024
@aooohan aooohan modified the milestones: 0.2.5, 0.3.0 Mar 14, 2024
@aooohan aooohan removed this from the 0.3.0 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants