Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: global option #88

Open
fangzhengjin opened this issue Mar 8, 2024 · 4 comments
Open

[BUG]: global option #88

fangzhengjin opened this issue Mar 8, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@fangzhengjin
Copy link
Contributor

Version
The version you are currently using
OS
macOS

Describe the bug

vfox use java@21 --global 

执行后没有报错,只是当前会话生效
必须使用下面这个才可以

vfox use --global java@21 

Screenshots[optional]
If applicable, add screenshots to help explain your problem.

@fangzhengjin fangzhengjin added the bug Something isn't working label Mar 8, 2024
@aooohan
Copy link
Member

aooohan commented Mar 8, 2024

感谢反馈!

vfox使用的是urfave/cli库, 这个是库的问题. 只能命令后面紧接着跟flag才能生效.

@aooohan aooohan added the invalid This doesn't seem right label Mar 8, 2024
@aooohan aooohan closed this as not planned Won't fix, can't repro, duplicate, stale Mar 8, 2024
@bytemain
Copy link
Member

bytemain commented Mar 8, 2024

urfave/cli support this feature on v3.0

urfave/cli#1568

just add a property to the flag to make it work

CleanShot 2024-03-08 at 13 49 31@2x

@aooohan aooohan reopened this Mar 8, 2024
@aooohan
Copy link
Member

aooohan commented Mar 8, 2024

urfave/cli support this feature on v3.0

urfave/cli#1568

just add a property to the flag to make it work

Wow, I'll fix this later. 👍

@aooohan
Copy link
Member

aooohan commented Mar 8, 2024

Oh damn, we are currently using v2, and it seems like a lot of things need to be changed when upgrading to v3, which is still alpha.

So I suggest that we wait until v3 is released before fixing this issue.

@aooohan aooohan removed the invalid This doesn't seem right label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants