Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose new InfluxDb 2.0 configuration options so Vert.x can support influxDb 2.0 connections #141

Closed
redkite58 opened this issue Jun 1, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@redkite58
Copy link

Seen in Vext.x version 4.3.1

The Vert.x Micrometer Metrics 4.3.1 release has now included the io.micrometer-> micrometer-registry-influx 1.8.4 as a compiled dependency. This dependency provides support for InfluxDb 2.0 connections (see micrometer-metrics/micrometer#1974 for more details).

InfluxDb 2.0 provides three new connection properties:

  • org
  • bucket
  • token

If these new configuration options are set then the InfluxDb 1.8.4 library will create InfluxDb 2.0 connections, if the old 'db' property is used the library will fall back to InfluxDb 1.0 connections.

The vertx.micrometer.VertxInfluxDbOptions class needs to be updated to support these new configuration operations. This should then enable Vert.x to support InfluxDb 2.0 connections.

@redkite58 redkite58 added the bug Something isn't working label Jun 1, 2022
@vietj
Copy link
Contributor

vietj commented Jun 1, 2022

can you contribute this @redkite58 ?

@tsegismont
Copy link
Contributor

@vietj I have asked @redkite58 to file this issue in https://groups.google.com/g/vertx/c/9mCsl4rKhhc/m/rIS_xANBBgAJ

@redkite58 you should start by adding the new properties to InfluxDBOptions and update its toMicrometerConfig.

@tsegismont tsegismont added enhancement New feature or request help wanted Extra attention is needed and removed bug Something isn't working labels Aug 10, 2022
@tsegismont
Copy link
Contributor

@redkite58 still want to contribute this?

@tsegismont tsegismont self-assigned this Oct 4, 2022
@tsegismont tsegismont added this to the 4.3.5 milestone Oct 4, 2022
@tsegismont tsegismont removed the help wanted Extra attention is needed label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants