Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthProvider service type #26

Open
Cafeinoman opened this issue Jun 10, 2016 · 4 comments
Open

AuthProvider service type #26

Cafeinoman opened this issue Jun 10, 2016 · 4 comments

Comments

@Cafeinoman
Copy link
Contributor

Is it planned to add a type to be able to discover AuthProvider service. It will be useful for a centralized auth in microservice architecture...
If you are interested, but not have time, I can work on this...

@cescoffier
Copy link
Member

👍

I like the idea. It was not planned, but definitely something we can add. Notice that service types are pluggable, so we can implement it in a separate project (or module under this project).

@cescoffier
Copy link
Member

@Cafeinoman
Copy link
Contributor Author

Yes, that's it. I begin to work on a (very) simple implementation couple weeks ago, but got a lot work. Missing a lot of test at this time. You can find it on my repo.

@cescoffier
Copy link
Member

cescoffier commented Jul 19, 2016

Just had a look. It looks good to me. Yes need more tests (especially polyglot test to be sure it's usable from groovy, js and ruby).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants