Errors on build - remove Avalonia from CSharpMath.Xaml.Tests and delete CSharpMath.Apple?

[charlesroddie]

Test failures:

Error: Test.cs(16,9): error CS0012: The type 'Color' is defined in an assembly that is not referenced. You must add a reference to assembly 'Avalonia.Visuals, Version=0.10.0.0, Culture=neutral, PublicKeyToken=c8d484a7012f9a8b'. [/home/runner/work/CSharpMath/CSharpMath/CSharpMath.Xaml.Tests.NuGet/CSharpMath.Xaml.Tests.NuGet.csproj]

Error: /home/runner/work/CSharpMath/CSharpMath/CSharpMath.Apple/Resources/ManifestResources.cs(17,13): error CS8602: Dereference of a possibly null reference. [/home/runner/work/CSharpMath/CSharpMath/CSharpMath.Editor.Tests/CSharpMath.Editor.Tests.csproj]
Error: /home/runner/work/CSharpMath/CSharpMath/CSharpMath.Apple/BackEnd/JsonMathTable.cs(25,27): error CS8604: Possible null reference argument for parameter 'value' in 'int Extensions.Value<int>(IEnumerable<JToken> value)'. [/home/runner/work/CSharpMath/CSharpMath/CSharpMath.Editor.Tests/CSharpMath.Editor.Tests.csproj]
Error: /home/runner/work/CSharpMath/CSharpMath/CSharpMath.Apple/BackEnd/JsonMathTable.cs(29,7): error CS8604: Possible null reference argument for parameter 'value' in 'int Extensions.Value<int>(IEnumerable<JToken> value)'. [/home/runner/work/CSharpMath/CSharpMath/CSharpMath.Editor.Tests/CSharpMath.Editor.Tests.csproj]
Error: /home/runner/work/CSharpMath/CSharpMath/CSharpMath.Apple/BackEnd/JsonMathTable.cs(50,7): error CS8604: Possible null reference argument for parameter 'value' in 'short Extensions.Value<short>(IEnumerable<JToken> value)'. [/home/runner/work/CSharpMath/CSharpMath/CSharpMath.Editor.Tests/CSharpMath.Editor.Tests.csproj]
Error: /home/runner/work/CSharpMath/CSharpMath/CSharpMath.Apple/BackEnd/JsonMathTable.cs(52,7): error CS8604: Possible null reference argument for parameter 'value' in 'short Extensions.Value<short>(IEnumerable<JToken> value)'. [/home/runner/work/CSharpMath/CSharpMath/CSharpMath.Editor.Tests/CSharpMath.Editor.Tests.csproj]
Error: /home/runner/work/CSharpMath/CSharpMath/CSharpMath.Apple/BackEnd/JsonMathTable.cs(126,7): error CS8604: Possible null reference argument for parameter 'value' in 'short Extensions.Value<short>(IEnumerable<JToken> value)'. [/home/runner/work/CSharpMath/CSharpMath/CSharpMath.Editor.Tests/CSharpMath.Editor.Tests.csproj]
Error: /home/runner/work/CSharpMath/CSharpMath/CSharpMath.Apple/BackEnd/JsonMathTable.cs(143,38): error CS8604: Possible null reference argument for parameter 'value' in 'string? Extensions.Value<string>(IEnumerable<JToken> value)'. [/home/runner/work/CSharpMath/CSharpMath/CSharpMath.Editor.Tests/CSharpMath.Editor.Tests.csproj]
Error: /home/runner/work/CSharpMath/CSharpMath/CSharpMath.Apple/BackEnd/JsonMathTable.cs(143,38): error CS8604: Possible null reference argument for parameter 'glyphName' in 'TGlyph IGlyphNameProvider<TGlyph>.GetGlyph(string glyphName)'. [/home/runner/work/CSharpMath/CSharpMath/CSharpMath.Editor.Tests/CSharpMath.Editor.Tests.csproj]
Error: /home/runner/work/CSharpMath/CSharpMath/CSharpMath.Apple/BackEnd/JsonMathTable.cs(144,31): error CS8604: Possible null reference argument for parameter 'value' in 'int Extensions.Value<int>(IEnumerable<JToken> value)'. [/home/runner/work/CSharpMath/CSharpMath/CSharpMath.Editor.Tests/CSharpMath.Editor.Tests.csproj]
Error: /home/runner/work/CSharpMath/CSharpMath/CSharpMath.Apple/BackEnd/JsonMathTable.cs(145,31): error CS8604: Possible null reference argument for parameter 'value' in 'int Extensions.Value<int>(IEnumerable<JToken> value)'. [/home/runner/work/CSharpMath/CSharpMath/CSharpMath.Editor.Tests/CSharpMath.Editor.Tests.csproj]
Error: /home/runner/work/CSharpMath/CSharpMath/CSharpMath.Apple/BackEnd/JsonMathTable.cs(146,31): error CS8604: Possible null reference argument for parameter 'value' in 'int Extensions.Value<int>(IEnumerable<JToken> value)'. [/home/runner/work/CSharpMath/CSharpMath/CSharpMath.Editor.Tests/CSharpMath.Editor.Tests.csproj]
Error: /home/runner/work/CSharpMath/CSharpMath/CSharpMath.Apple/BackEnd/JsonMathTable.cs(147,11): error CS8604: Possible null reference argument for parameter 'value' in 'bool Extensions.Value<bool>(IEnumerable<JToken> value)'. [/home/runner/work/CSharpMath/CSharpMath/CSharpMath.Editor.Tests/CSharpMath.Editor.Tests.csproj]
Error: /home/runner/work/CSharpMath/CSharpMath/CSharpMath.Apple/BackEnd/JsonMathTable.cs(155,37): error CS8604: Possible null reference argument for parameter 'variants' in '(IEnumerable<TGlyph> variants, int count) JsonMathTable<TFont, TGlyph>.GetVariantsForGlyph(TGlyph rawGlyph, JToken variants)'. [/home/runner/work/CSharpMath/CSharpMath/CSharpMath.Editor.Tests/CSharpMath.Editor.Tests.csproj]
Error: /home/runner/work/CSharpMath/CSharpMath/CSharpMath.Apple/BackEnd/JsonMathTable.cs(157,37): error CS8604: Possible null reference argument for parameter 'variants' in '(IEnumerable<TGlyph> variants, int count) JsonMathTable<TFont, TGlyph>.GetVariantsForGlyph(TGlyph rawGlyph, JToken variants)'. [/home/runner/work/CSharpMath/CSharpMath/CSharpMath.Editor.Tests/CSharpMath.Editor.Tests.csproj]
Error: /home/runner/work/CSharpMath/CSharpMath/CSharpMath.Apple/BackEnd/JsonMathTable.cs(175,11): error CS8602: Dereference of a possibly null reference. [/home/runner/work/CSharpMath/CSharpMath/CSharpMath.Editor.Tests/CSharpMath.Editor.Tests.csproj]
Error: /home/runner/work/CSharpMath/CSharpMath/CSharpMath.Apple/BackEnd/JsonMathTable.cs(211,23): error CS8602: Dereference of a possibly null reference. [/home/runner/work/CSharpMath/CSharpMath/CSharpMath.Editor.Tests/CSharpMath.Editor.Tests.csproj]

I suggest deleting CSharpMath.Xaml.Tests and removing Avalonia from CSharpMath.Apple unless anyone wants to maintain those.

[charlesroddie]

While it's possible to fix the tests, there are other reasons for these deletions:

Apple:

• Apple projects are on an obsolete xamarin.ios1.0 TargetFramework and they would need to be updated to remain in the repo.
• Apple projects are provided for by SkiaSharp and so there is minimal benefit of maintaining apple projects.
• Many projects can be deleted: CSharpMath.Ios, CSharpMath.Ios.Example, CSharpMath.Ios.Tests.

Avalonia:

• Removing the tests would simplify the project structure of CSharpMath.Xaml.Tests since it would test only Forms, and the project itself can be deleted together with the Forms projects when Forms goes out of support on May 1 2024.